Skip to content

Conversation

lonitra
Copy link
Member

@lonitra lonitra commented Oct 2, 2024

Summary

Addresses remaining missing documentation for System.Drawing as outlined dotnet/winforms#11858 (comment)
Fixes dotnet/winforms#11858

@lonitra lonitra requested a review from a team as a code owner October 2, 2024 22:58
@ghost ghost added the area-System.Drawing label Oct 2, 2024
@lonitra
Copy link
Member Author

lonitra commented Oct 2, 2024

cc: @carlossanlop

Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions.

Co-authored-by: Carlos Sánchez López <[email protected]>

This comment was marked as outdated.

Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more suggestion, otherwise LGTM.

Co-authored-by: Carlos Sánchez López <[email protected]>
Copy link

Learn Build status updates of commit 339c17b:

✅ Validation status: passed

File Status Preview URL Details
xml/ns-System.Drawing.Imaging.Effects.xml ✅Succeeded View
xml/System.Drawing.Imaging.Effects/Effect.xml ✅Succeeded View
xml/System.Drawing/SystemColors.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 2, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-drawing

Copy link

Learn Build status updates of commit 97f1ff2:

✅ Validation status: passed

File Status Preview URL Details
xml/ns-System.Drawing.Imaging.Effects.xml ✅Succeeded View
xml/System.Drawing.Imaging.Effects/Effect.xml ✅Succeeded View
xml/System.Drawing/SystemColors.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Co-authored-by: Genevieve Warren <[email protected]>
Copy link

Learn Build status updates of commit 9a8d429:

✅ Validation status: passed

File Status Preview URL Details
xml/ns-System.Drawing.Imaging.Effects.xml ✅Succeeded View
xml/System.Drawing.Imaging.Effects/Effect.xml ✅Succeeded View
xml/System.Drawing/SystemColors.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@lonitra
Copy link
Member Author

lonitra commented Oct 8, 2024

@gewarren @carlossanlop if all looks good could you please merge?

@gewarren gewarren merged commit a912c46 into dotnet:main Oct 8, 2024
4 checks passed
@lonitra lonitra deleted the sysdrawingremaining branch October 8, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Drawing community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port System.Drawing docs for .NET 9 APIs
3 participants