Skip to content

Fix reference to SslCertificateTrust on Ssl*AuthenticationOptions #10505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 9, 2024
Merged

Fix reference to SslCertificateTrust on Ssl*AuthenticationOptions #10505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5df2942
Fix reference to SslCertificateTrust on Ssl*AuthenticationOptions
rzikm Oct 7, 2024
6973ba4
Fix build
rzikm Oct 7, 2024
8d421c8
Fix class name
rzikm Oct 7, 2024
4992391
Reword
rzikm Oct 7, 2024
2e9a5bf
Suggestions from code review
rzikm Oct 8, 2024
0bdf9e4
Apply suggestions from code review
rzikm Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions xml/System.Net.Security/SslClientAuthenticationOptions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,19 @@
<ReturnType>System.Security.Cryptography.X509Certificates.X509ChainPolicy</ReturnType>
</ReturnValue>
<Docs>
<summary>Gets or sets an optional customized policy for remote certificate validation. If not <see langword="null" />, <see cref="P:System.Net.Security.SslClientAuthenticationOptions.CertificateRevocationCheckMode" /> and <see cref="T:System.Net.Security.SslCertificateTrust" /> are ignored.</summary>
<summary>Gets or sets an optional customized policy for remote certificate validation.</summary>
<value>To be added.</value>
<remarks>To be added.</remarks>
<remarks>
<format type="text/markdown"><![CDATA[

## Remarks

When the value of this property is not `null`:

- The value of the <xref:System.Net.Security.SslClientAuthenticationOptions.CertificateRevocationCheckMode> property is ignored.
- Any <xref:System.Net.Security.SslCertificateTrust> associated with the <xref:System.Net.Security.SslClientAuthenticationOptions.ClientCertificateContext> is ignored.
]]></format>
</remarks>
</Docs>
</Member>
<Member MemberName="CertificateRevocationCheckMode">
Expand Down
16 changes: 13 additions & 3 deletions xml/System.Net.Security/SslServerAuthenticationOptions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,9 +189,19 @@
<ReturnType>System.Security.Cryptography.X509Certificates.X509ChainPolicy</ReturnType>
</ReturnValue>
<Docs>
<summary>Gets or sets an optional customized policy for remote certificate validation. If not <see langword="null" />, <see cref="P:System.Net.Security.SslServerAuthenticationOptions.CertificateRevocationCheckMode" /> and <see cref="T:System.Net.Security.SslCertificateTrust" /> are ignored.</summary>
<summary>Gets or sets an optional customized policy for remote certificate validation.</summary>
<value>To be added.</value>
<remarks>To be added.</remarks>
<remarks>
<format type="text/markdown"><![CDATA[

## Remarks

When the value of this property is not `null`:

- The value of the <xref:System.Net.Security.SslServerAuthenticationOptions.CertificateRevocationCheckMode> property is ignored.
- If an <xref:System.Net.Security.SslCertificateTrust> was provided to the value in the <xref:System.Net.Security.SslServerAuthenticationOptions.ServerCertificateContext> property, the trust list `SslCertificateTrust` will be sent in the handshake (when so configured), but the trust settings from this property aren't used when verifying any client authentication certificates.
]]></format>
</remarks>
</Docs>
</Member>
<Member MemberName="CertificateRevocationCheckMode">
Expand Down Expand Up @@ -494,4 +504,4 @@
</Docs>
</Member>
</Members>
</Type>
</Type>