Skip to content

Add missing return values for VectorX.Create(ROS<float> values) #10511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2024
Merged

Add missing return values for VectorX.Create(ROS<float> values) #10511

merged 1 commit into from
Oct 10, 2024

Conversation

jeffhandley
Copy link
Member

Fixes dotnet/runtime#105981 for .NET 9, adding the missing return value docs.

@jeffhandley jeffhandley self-assigned this Oct 8, 2024
@jeffhandley jeffhandley requested a review from a team as a code owner October 8, 2024 05:43
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 0115ada:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Numerics/Vector2.xml ✅Succeeded View
xml/System.Numerics/Vector3.xml ✅Succeeded View
xml/System.Numerics/Vector4.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

carlossanlop
carlossanlop approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging to include it in the final intellisense flow for 9.0.

@carlossanlop carlossanlop merged commit ef19a53 into dotnet:main Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

@tannergooding tannergooding Awaiting requested review from tannergooding

+1 more reviewer

@carlossanlop carlossanlop carlossanlop approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jeffhandley jeffhandley

Labels
area-System.Numerics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port System.Numerics docs for .NET 9 APIs
3 participants
@jeffhandley @carlossanlop @gewarren