Skip to content

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Oct 9, 2024

Fixes #9990

(View by commit. Last commit is the doc updates.)

@ghost ghost added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Oct 9, 2024

This comment was marked as outdated.

This comment was marked as outdated.

@gewarren gewarren requested a review from carlossanlop October 9, 2024 17:48
Copy link

Learn Build status updates of commit 4121e07:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/Microsoft.Extensions.DependencyInjection/AsyncStateExtensions.xml ⚠️Warning View Details
xml/Microsoft.Extensions.DependencyInjection/ResilienceHttpClientBuilderExtensions.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Http.Resilience/HedgingEndpointOptions.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Http.Resilience/HttpCircuitBreakerStrategyOptions.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Http.Resilience/HttpClientHedgingResiliencePredicates.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Http.Resilience/HttpClientResiliencePredicates.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Http.Resilience/HttpHedgingStrategyOptions.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Http.Resilience/HttpRateLimiterStrategyOptions.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Http.Resilience/HttpRetryStrategyOptions.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Http.Resilience/HttpStandardResilienceOptions.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Http.Resilience/HttpTimeoutStrategyOptions.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Http.Resilience/ResilienceHandler.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Logging.AzureAppServices/BatchingLoggerProvider.xml ⚠️Warning View Details
xml/System.Reflection.Emit/PersistedAssemblyBuilder.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Http.Diagnostics/HttpRouteParameterRedactionMode.xml 💡Suggestion View Details
xml/FrameworksIndex/net-6.0.xml ✅Succeeded
xml/FrameworksIndex/net-7.0.xml ✅Succeeded
xml/FrameworksIndex/net-8.0.xml ✅Succeeded
xml/FrameworksIndex/net-9.0.xml ✅Succeeded
xml/FrameworksIndex/netframework-4.6.2.xml ✅Succeeded
xml/FrameworksIndex/netframework-4.7.1.xml ✅Succeeded
xml/FrameworksIndex/netframework-4.7.2.xml ✅Succeeded
xml/FrameworksIndex/netframework-4.7.xml ✅Succeeded
xml/FrameworksIndex/netframework-4.8.1.xml ✅Succeeded
xml/FrameworksIndex/netframework-4.8.xml ✅Succeeded

This comment lists only the first 25 files in the pull request.

xml/Microsoft.Extensions.DependencyInjection/AsyncStateExtensions.xml

  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Microsoft.Extensions.AsyncState.IAsyncLocalContext`1'.

xml/Microsoft.Extensions.DependencyInjection/ResilienceHttpClientBuilderExtensions.xml

  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Polly.ResiliencePipelineBuilder`1'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Polly.ResiliencePipelineBuilder`1'.

xml/Microsoft.Extensions.Http.Resilience/HedgingEndpointOptions.xml

  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Polly.Timeout.TimeoutStrategyOptions.Timeout'.

xml/Microsoft.Extensions.Http.Resilience/HttpCircuitBreakerStrategyOptions.xml

  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Polly.CircuitBreaker.CircuitBreakerStrategyOptions`1'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Polly.CircuitBreaker.CircuitBreakerStrategyOptions`1'.

xml/Microsoft.Extensions.Http.Resilience/HttpClientHedgingResiliencePredicates.xml

  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Polly.Outcome`1'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Polly.Outcome`1'.

xml/Microsoft.Extensions.Http.Resilience/HttpClientResiliencePredicates.xml

  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Polly.Outcome`1'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Polly.Outcome`1'.

xml/Microsoft.Extensions.Http.Resilience/HttpHedgingStrategyOptions.xml

  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Polly.Hedging.HedgingStrategyOptions`1'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Polly.Hedging.HedgingStrategyOptions`1'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Polly.CircuitBreaker.BrokenCircuitException'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Polly.Timeout.TimeoutRejectedException'.

xml/Microsoft.Extensions.Http.Resilience/HttpRateLimiterStrategyOptions.xml

  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Polly.RateLimiting.RateLimiterStrategyOptions'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Polly.RateLimiting.RateLimiterStrategyOptions'.

xml/Microsoft.Extensions.Http.Resilience/HttpRetryStrategyOptions.xml

  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Polly.Timeout.TimeoutRejectedException'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Polly.Retry.RetryStrategyOptions`1'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Polly.Retry.RetryStrategyOptions`1'.

xml/Microsoft.Extensions.Http.Resilience/HttpStandardResilienceOptions.xml

  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Polly.Timeout.TimeoutStrategyOptions.Timeout'.

xml/Microsoft.Extensions.Http.Resilience/HttpTimeoutStrategyOptions.xml

  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Polly.Timeout.TimeoutStrategyOptions'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Polly.Timeout.TimeoutStrategyOptions'.

xml/Microsoft.Extensions.Http.Resilience/ResilienceHandler.xml

  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Polly.ResiliencePipeline`1'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Polly.ResiliencePipeline`1'.

xml/Microsoft.Extensions.Logging.AzureAppServices/BatchingLoggerProvider.xml

  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Microsoft.Extensions.Logging.AzureAppServices.Internal.BatchingLogger'.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gewarren gewarren enabled auto-merge (squash) October 9, 2024 21:01
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

@gewarren gewarren merged commit 06e50eb into dotnet:main Oct 10, 2024
4 checks passed
@gewarren gewarren deleted the net9-rc2-chunked branch October 10, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update API ref for .NET 9 RC 2
2 participants