Skip to content

Conversation

buyaa-n
Copy link
Contributor

@buyaa-n buyaa-n commented Oct 14, 2024

Summary

Improve return values of Base64Url.Try* methods, clarify it returns false if destination is too small

Relates to dotnet/runtime#108834 (comment)

@buyaa-n buyaa-n requested a review from a team as a code owner October 14, 2024 19:10
@ghost ghost added the area-System.Buffers label Oct 14, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-buffers

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@gewarren gewarren enabled auto-merge (squash) October 14, 2024 19:28
Copy link

Learn Build status updates of commit 4dcdbb0:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Buffers.Text/Base64Url.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit b778bdc into dotnet:main Oct 14, 2024
4 checks passed
@buyaa-n buyaa-n deleted the try-return branch October 14, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants