Skip to content

Conversation

gewarren
Copy link
Contributor

Fixes #10045.

@gewarren gewarren requested a review from a team as a code owner October 18, 2024 19:21
@gewarren gewarren enabled auto-merge (squash) October 18, 2024 19:21
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-text-json

Copy link

Learn Build status updates of commit cc30a3d:

💡 Validation status: suggestions

File Status Preview URL Details
xml/System.Text.Json.Serialization/JsonSourceGenerationMode.xml 💡Suggestion View Details

xml/System.Text.Json.Serialization/JsonSourceGenerationMode.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Enum_NoRemarks] Please note: <remarks> node on Enum fields will be ignored.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link

Learn Build status updates of commit 1fa54e9:

💡 Validation status: suggestions

File Status Preview URL Details
xml/System.Text.Json.Serialization/JsonSourceGenerationMode.xml 💡Suggestion View Details

xml/System.Text.Json.Serialization/JsonSourceGenerationMode.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Enum_NoRemarks] Please note: <remarks> node on Enum fields will be ignored.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gewarren gewarren merged commit 9193540 into main Oct 18, 2024
4 checks passed
@gewarren gewarren deleted the gewarren-patch-17 branch October 18, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links to members from other types are currently confusing
2 participants