Skip to content

Remove SourceLink info for platform extension monikers #10652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2024
Merged

Remove SourceLink info for platform extension monikers #10652

merged 1 commit into from
Nov 8, 2024

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Nov 7, 2024

These monikers no longer exist, so this info isn't needed.

@gewarren gewarren requested a review from a team as a code owner November 7, 2024 19:58
@ghost
Copy link

ghost commented Nov 7, 2024

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 7, 2024
@ghost
Copy link

ghost commented Nov 7, 2024

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@gewarren gewarren added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 7, 2024
@gewarren gewarren enabled auto-merge (squash) November 7, 2024 20:01
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 9fce261:

✅ Validation status: passed

File Status Preview URL Details
xml/SourceLinkInformation/dotnet-plat-ext-7.0/Microsoft.Extensions.Caching.Abstractions.json ✅Succeeded n/a (file deleted or renamed)
xml/SourceLinkInformation/dotnet-plat-ext-7.0/Microsoft.Extensions.Caching.Memory.json ✅Succeeded n/a (file deleted or renamed)
xml/SourceLinkInformation/dotnet-plat-ext-7.0/Microsoft.Extensions.Configuration.Abstractions.json ✅Succeeded n/a (file deleted or renamed)
xml/SourceLinkInformation/dotnet-plat-ext-7.0/Microsoft.Extensions.Configuration.Binder.json ✅Succeeded n/a (file deleted or renamed)
xml/SourceLinkInformation/dotnet-plat-ext-7.0/Microsoft.Extensions.Configuration.CommandLine.json ✅Succeeded n/a (file deleted or renamed)
xml/SourceLinkInformation/dotnet-plat-ext-7.0/Microsoft.Extensions.Configuration.EnvironmentVariables.json ✅Succeeded n/a (file deleted or renamed)
xml/SourceLinkInformation/dotnet-plat-ext-7.0/Microsoft.Extensions.Configuration.FileExtensions.json ✅Succeeded n/a (file deleted or renamed)
xml/SourceLinkInformation/dotnet-plat-ext-7.0/Microsoft.Extensions.Configuration.Ini.json ✅Succeeded n/a (file deleted or renamed)
xml/SourceLinkInformation/dotnet-plat-ext-7.0/Microsoft.Extensions.Configuration.json ✅Succeeded n/a (file deleted or renamed)
xml/SourceLinkInformation/dotnet-plat-ext-7.0/Microsoft.Extensions.Configuration.Json.json ✅Succeeded n/a (file deleted or renamed)
xml/SourceLinkInformation/dotnet-plat-ext-7.0/Microsoft.Extensions.Configuration.KeyPerFile.json ✅Succeeded n/a (file deleted or renamed)
xml/SourceLinkInformation/dotnet-plat-ext-7.0/Microsoft.Extensions.Configuration.UserSecrets.json ✅Succeeded n/a (file deleted or renamed)
xml/SourceLinkInformation/dotnet-plat-ext-7.0/Microsoft.Extensions.Configuration.Xml.json ✅Succeeded n/a (file deleted or renamed)
xml/SourceLinkInformation/dotnet-plat-ext-7.0/Microsoft.Extensions.DependencyInjection.Abstractions.json ✅Succeeded n/a (file deleted or renamed)
xml/SourceLinkInformation/dotnet-plat-ext-7.0/Microsoft.Extensions.DependencyInjection.json ✅Succeeded n/a (file deleted or renamed)
xml/SourceLinkInformation/dotnet-plat-ext-7.0/Microsoft.Extensions.DependencyModel.json ✅Succeeded n/a (file deleted or renamed)
xml/SourceLinkInformation/dotnet-plat-ext-7.0/Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions.json ✅Succeeded n/a (file deleted or renamed)
xml/SourceLinkInformation/dotnet-plat-ext-7.0/Microsoft.Extensions.Diagnostics.HealthChecks.EntityFrameworkCore.json ✅Succeeded n/a (file deleted or renamed)
xml/SourceLinkInformation/dotnet-plat-ext-7.0/Microsoft.Extensions.Diagnostics.HealthChecks.json ✅Succeeded n/a (file deleted or renamed)
xml/SourceLinkInformation/dotnet-plat-ext-7.0/Microsoft.Extensions.FileProviders.Abstractions.json ✅Succeeded n/a (file deleted or renamed)
xml/SourceLinkInformation/dotnet-plat-ext-7.0/Microsoft.Extensions.FileProviders.Composite.json ✅Succeeded n/a (file deleted or renamed)
xml/SourceLinkInformation/dotnet-plat-ext-7.0/Microsoft.Extensions.FileProviders.Embedded.json ✅Succeeded n/a (file deleted or renamed)
xml/SourceLinkInformation/dotnet-plat-ext-7.0/Microsoft.Extensions.FileProviders.Physical.json ✅Succeeded n/a (file deleted or renamed)
xml/SourceLinkInformation/dotnet-plat-ext-7.0/Microsoft.Extensions.FileSystemGlobbing.json ✅Succeeded n/a (file deleted or renamed)
xml/SourceLinkInformation/dotnet-plat-ext-7.0/Microsoft.Extensions.Hosting.Abstractions.json ✅Succeeded n/a (file deleted or renamed)

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

BillWagner
BillWagner approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM Let's :shipit:

@gewarren gewarren merged commit c5f5dcd into dotnet:main Nov 8, 2024
4 checks passed
@gewarren gewarren deleted the remove-old-sourcelink-monikers branch November 8, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees

@gewarren gewarren

Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gewarren @BillWagner