Skip to content

SFI: ROPC fixes for ADO.NET #10728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 6, 2024
Merged

SFI: ROPC fixes for ADO.NET #10728

merged 2 commits into from
Dec 6, 2024

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Dec 6, 2024 •
edited
Loading

In most cases I just deleted the example, since the page views were very low.

Contributes to #10434.

(Hide whitespace changes.)

@ghost ghost added the area-Infrastructure label Dec 6, 2024
@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit d2e747f:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/VS_Snippets_ADO.NET/DataWorks DbConnectionStringBuilder.Values/CS/source.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_ADO.NET/DataWorks OdbcConnectionStringBuilder.Keys/CS/source.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_ADO.NET/DataWorks OdbcConnectionStringBuilder.Multiple/CS/source.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_ADO.NET/DataWorks OdbcConnectionStringBuilder/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/DataWorks OdbcConnectionStringBuilder/CS/source.cs ✅Succeeded View
snippets/csharp/VS_Snippets_ADO.NET/DataWorks OleDbConnectionStringBuilder.Ctor/CS/source.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_ADO.NET/DataWorks OleDbConnectionStringBuilder.Keys/CS/source.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_ADO.NET/DataWorks OleDbConnectionStringBuilder.Provider/CS/source.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_ADO.NET/DataWorks OracleConnectionStringBuilder.Ctor/CS/source.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_ADO.NET/DataWorks OracleConnectionStringBuilder.IntegratedSecurity/CS/source.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_ADO.NET/DataWorks OracleConnectionStringBuilder.Remove/CS/source.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_ADO.NET/DataWorks OracleConnectionStringBuilder/CS/source.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_ADO.NET/DataWorks SqlConnection.ChangePassword/CS/source.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_ADO.NET/DataWorks SqlConnectionStringBuilder.IntegratedSecurity/CS/source.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_ADO.NET/DataWorks SqlConnectionStringBuilder.Password/CS/source.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_ADO.NET/DataWorks SqlConnectionStringBuilder.Remove/CS/Project.csproj ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_ADO.NET/DataWorks SqlConnectionStringBuilder.Remove/CS/source.cs ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_ADO.NET/DataWorks OdbcConnectionStringBuilder.Keys/VB/source.vb ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_ADO.NET/DataWorks OdbcConnectionStringBuilder.Multiple/VB/source.vb ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_ADO.NET/DataWorks OdbcConnectionStringBuilder/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_ADO.NET/DataWorks OdbcConnectionStringBuilder/VB/source.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_ADO.NET/DataWorks OleDbConnectionStringBuilder.Ctor/VB/source.vb ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_ADO.NET/DataWorks OleDbConnectionStringBuilder.Keys/VB/source.vb ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_ADO.NET/DataWorks OleDbConnectionStringBuilder.Provider/VB/source.vb ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_ADO.NET/DataWorks OracleConnectionStringBuilder.Ctor/VB/source.vb ✅Succeeded n/a (file deleted or renamed)

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit b4a8b42 into dotnet:main Dec 6, 2024
4 checks passed
@gewarren gewarren deleted the ropc-december branch December 6, 2024 23:22
@gewarren gewarren changed the title ROPC fixes for ADO.NET SFI: ROPC fixes for ADO.NET Dec 6, 2024
@gewarren gewarren added area-System.Data Data APIs (ADO.NET, XML, etc). sfi-ropc and removed area-Infrastructure labels Apr 24, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @roji, @ajcvickers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@David-Engel David-Engel David-Engel approved these changes

@cheenamalhotra cheenamalhotra Awaiting requested review from cheenamalhotra cheenamalhotra is a code owner

@ajcvickers ajcvickers Awaiting requested review from ajcvickers

Assignees

@gewarren gewarren

Labels
area-System.Data Data APIs (ADO.NET, XML, etc). sfi-ropc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gewarren @David-Engel