Skip to content

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Dec 7, 2024

Contributes to #10434.

In most cases, insecure examples were deleted.

Hide whitespace changes in diff.

@gewarren gewarren requested review from Rick-Anderson and a team as code owners December 7, 2024 01:23
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Dec 7, 2024
@ghost
Copy link

ghost commented Dec 7, 2024

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

1 similar comment
@ghost
Copy link

ghost commented Dec 7, 2024

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

This comment was marked as outdated.

Copy link

Learn Build status updates of commit ffe1d32:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/VS_Snippets_WebNet/FormsAuthenticationHashPassword/CS/formsauthenticationhashpasswordcs.aspx ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_WebNet/System.Web.Management.SqlServices/CS/usingsqlservices.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_WebNet/System.Web.Security.IMembershipProvider/CS/imembershipprovider.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_WebNet/System.Web.Security.IMembershipProvider/CS/imembershipprovidergetallusers.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_WebNet/System.Web.Security.MembershipUser.Constructor/CS/newuser.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_WebNet/System.Web.UI.WebControls.ChangePassword.OnChangingPassword/CS/changepassword_cs.aspx ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_WebNet/System.Web.UI.WebControls.ChangePassword/CS/changepassword_cs.aspx ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_WebNet/System.Web.UI.WebControls.ParameterCollection_2/CS/paramcoll2cs.aspx ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_WebNet/System.Web.UI.WebControls.SendMailErrorEventHandler/CS/changepassword_cs.aspx ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_WebNet/FormsAuthenticationHashPassword/VB/formsauthenticationhashpasswordvb.aspx ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_WebNet/System.Web.Management.SqlServices/VB/usingsqlservices.vb ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_WebNet/System.Web.Security.IMembershipProvider/VB/imembershipprovider.vb ✅Succeeded
snippets/visualbasic/VS_Snippets_WebNet/System.Web.Security.IMembershipProvider/VB/imembershipprovidergetallusers.vb ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_WebNet/System.Web.Security.IMembershipProvider/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_WebNet/System.Web.UI.WebControls.ChangePassword.OnChangingPassword/VB/changepassword_vb.aspx ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_WebNet/System.Web.UI.WebControls.ParameterCollection_2/VB/paramcoll2vb.aspx ✅Succeeded n/a (file deleted or renamed)
xml/System.Web.Configuration/ProcessModelSection.xml ✅Succeeded View
xml/System.Web.Management/SessionStateType.xml ✅Succeeded View
xml/System.Web.Management/SqlExecutionException.xml ✅Succeeded View
xml/System.Web.Management/SqlFeatures.xml ✅Succeeded View
xml/System.Web.Management/SqlServices.xml ✅Succeeded View
xml/System.Web.Security/ActiveDirectoryMembershipProvider.xml ✅Succeeded View
xml/System.Web.Security/FormsAuthentication.xml ✅Succeeded View
xml/System.Web.Security/MembershipUser.xml ✅Succeeded View
xml/System.Web.Security/MembershipUserCollection.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren enabled auto-merge (squash) December 10, 2024 17:57
@gewarren
Copy link
Contributor Author

Ping @Rick-Anderson

Copy link
Contributor

@Rick-Anderson Rick-Anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this moves the sticks.

@gewarren gewarren merged commit e662567 into dotnet:main Jan 6, 2025
4 checks passed
@gewarren gewarren deleted the ropc-december-ii branch January 10, 2025 17:24
@gewarren gewarren added area-System.Web sfi-ropc and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants