Skip to content

Conversation

gewarren
Copy link
Contributor

Follow up to #10730.

@ghost ghost added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Dec 12, 2024

This comment was marked as outdated.

@gewarren gewarren marked this pull request as ready for review December 12, 2024 04:12
@gewarren gewarren requested a review from a team as a code owner December 12, 2024 04:12
@gewarren gewarren enabled auto-merge (squash) December 12, 2024 04:13
Copy link

Learn Build status updates of commit 00ed4b3:

✅ Validation status: passed

File Status Preview URL Details
snippets/cpp/VS_Snippets_Remoting/WebRequest_PreAuthenticate/CPP/webrequest_preauthenticate.cpp ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Net/Authorization/.ctor/ClientCloneBasic.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Net/CookieCollection/Item/CookiesPage.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Net/CookieCollection/Item/CookiesPage1.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Net/HttpWebRequest/ConnectionGroupName/source.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Net/SocketPermission/.ctor/DateServer_SocketPermission.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Net/SocketPermission/ConnectList/DateServer_SocketPermission.cs ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_CFX/cfx_wf_gettingstarted/vb/activitylibrary1/activitylibrary1.vbproj ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_CFX/cfx_wf_gettingstarted/vb/activitylibrary1/my project/application.designer.vb ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_CFX/cfx_wf_gettingstarted/vb/activitylibrary1/my project/application.myapp ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_CFX/cfx_wf_gettingstarted/vb/activitylibrary1/my project/assemblyinfo.vb ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_CFX/cfx_wf_gettingstarted/vb/activitylibrary1/my project/resources.designer.vb ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_CFX/cfx_wf_gettingstarted/vb/activitylibrary1/my project/resources.resx ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_CFX/cfx_wf_gettingstarted/vb/activitylibrary1/my project/settings.designer.vb ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_CFX/cfx_wf_gettingstarted/vb/activitylibrary1/my project/settings.settings ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_CFX/cfx_wf_gettingstarted/vb/activitylibrary1/prompt.xaml ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_CFX/cfx_wf_gettingstarted/vb/workflowconsoleapplication1/app.config ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_CFX/cfx_wf_gettingstarted/vb/workflowconsoleapplication1/my project/application.designer.vb ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_CFX/cfx_wf_gettingstarted/vb/workflowconsoleapplication1/my project/application.myapp ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_CFX/cfx_wf_gettingstarted/vb/workflowconsoleapplication1/my project/assemblyinfo.vb ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_CFX/cfx_wf_gettingstarted/vb/workflowconsoleapplication1/my project/resources.designer.vb ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_CFX/cfx_wf_gettingstarted/vb/workflowconsoleapplication1/my project/resources.resx ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_CFX/cfx_wf_gettingstarted/vb/workflowconsoleapplication1/my project/settings.designer.vb ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_CFX/cfx_wf_gettingstarted/vb/workflowconsoleapplication1/my project/settings.settings ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_CFX/cfx_wf_gettingstarted/vb/workflowconsoleapplication1/snippets.5000.json ✅Succeeded n/a (file deleted or renamed)

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Let's :shipit:

(You'll have to override the checks, so automerge won't work)

@gewarren gewarren disabled auto-merge December 12, 2024 15:48
@gewarren gewarren merged commit 6d9e1a5 into dotnet:main Dec 12, 2024
3 of 4 checks passed
@gewarren gewarren deleted the orphaned-snippets-1211 branch December 12, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants