Skip to content

[Sytem.Windows*] Add table headers for accessibility #10777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 20, 2024
Merged

[Sytem.Windows*] Add table headers for accessibility #10777

merged 2 commits into from
Dec 20, 2024

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Dec 20, 2024 •
edited
Loading

Contributes to #9813

(Hide whitespace changes.)

@gewarren gewarren requested review from merriemcgaw, JeremyKuhne and a team as code owners December 20, 2024 05:08
@ghost ghost added the area-Infrastructure label Dec 20, 2024
@gewarren gewarren requested a review from a team as a code owner December 20, 2024 05:11
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit b452202:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Windows.Automation/AutomationProperties.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/BulletDecorator.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/ButtonBase.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/DocumentPageView.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/DocumentViewerBase.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/GridViewRowPresenterBase.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/MenuBase.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/Popup.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/RangeBase.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/RepeatButton.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/ScrollBar.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/Selector.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/StatusBar.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/TextBoxBase.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/Thumb.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/TickBar.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/ToggleButton.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/ToolBarOverflowPanel.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/Track.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/UniformGrid.xml ✅Succeeded View
xml/System.Windows.Controls.Ribbon.Primitives/RibbonContextualTabGroupsPanel.xml ✅Succeeded View
xml/System.Windows.Controls.Ribbon.Primitives/RibbonTabHeadersPanel.xml ✅Succeeded View
xml/System.Windows.Controls.Ribbon.Primitives/RibbonTitlePanel.xml ✅Succeeded View
xml/System.Windows.Controls.Ribbon.Primitives/StarLayoutInfo.xml ✅Succeeded View
xml/System.Windows.Controls.Ribbon/Ribbon.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit eb5b7de:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Windows.Themes/BulletChrome.xml ✅Succeeded View
xml/Microsoft.Windows.Themes/ButtonChrome.xml ✅Succeeded View
xml/Microsoft.Windows.Themes/ClassicBorderDecorator.xml ✅Succeeded View
xml/Microsoft.Windows.Themes/ListBoxChrome.xml ✅Succeeded View
xml/Microsoft.Windows.Themes/ScrollChrome.xml ✅Succeeded View
xml/Microsoft.Windows.Themes/SystemDropShadowChrome.xml ✅Succeeded View
xml/System.Windows.Automation/AutomationProperties.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/BulletDecorator.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/ButtonBase.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/DocumentPageView.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/DocumentViewerBase.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/GridViewRowPresenterBase.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/MenuBase.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/Popup.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/RangeBase.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/RepeatButton.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/ScrollBar.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/Selector.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/StatusBar.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/TextBoxBase.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/Thumb.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/TickBar.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/ToggleButton.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/ToolBarOverflowPanel.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/Track.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

BillWagner
BillWagner reviewed Dec 20, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

I admit to skimming through the diffs, and they look great.

@gewarren gewarren merged commit d09267e into dotnet:main Dec 20, 2024
4 checks passed
@gewarren gewarren deleted the table-headers branch December 20, 2024 15:41
@gewarren
Copy link
Contributor Author

Thanks @BillWagner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@merriemcgaw merriemcgaw Awaiting requested review from merriemcgaw merriemcgaw is a code owner

@JeremyKuhne JeremyKuhne Awaiting requested review from JeremyKuhne JeremyKuhne is a code owner

Assignees

@gewarren gewarren

Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gewarren @BillWagner