-
Couldn't load subscription status.
- Fork 1.6k
Misc notes for LCID deprecation and Metric observable counters report… #10859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @tommcdon |
|
@gewarren could you please help review this change? It is just repeated notes. Thanks! |
|
@noahfalk I am adding some notes to the observable counters to clarify how these should be used. Could you please have a quick look at this part of the change? Thanks! |
|
Learn Build status updates of commit 12f18b9:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| xml/System.Globalization/CultureInfo.xml | View | Details | |
| xml/System.Diagnostics.Metrics/Meter.xml | ✅Succeeded | View | |
| xml/System.Diagnostics.Metrics/ObservableCounter`1.xml | ✅Succeeded | View | |
| xml/System.Diagnostics.Metrics/ObservableUpDownCounter`1.xml | ✅Succeeded | View |
xml/System.Globalization/CultureInfo.xml
- Line 0, Column 0: [Warning: disallowed-html-tag - See documentation]
HTML tag 'format' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some code fencing to prevent localization.
Co-authored-by: Genevieve Warren <[email protected]>
|
Learn Build status updates of commit 25be289:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| xml/System.Globalization/CultureInfo.xml | View | Details | |
| xml/System.Diagnostics.Metrics/Meter.xml | ✅Succeeded | View | |
| xml/System.Diagnostics.Metrics/ObservableCounter`1.xml | ✅Succeeded | View | |
| xml/System.Diagnostics.Metrics/ObservableUpDownCounter`1.xml | ✅Succeeded | View |
xml/System.Globalization/CultureInfo.xml
- Line 0, Column 0: [Warning: disallowed-html-tag - See documentation]
HTML tag 'format' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
No description provided.