Skip to content

Conversation

@tarekgh
Copy link
Member

@tarekgh tarekgh commented Jan 22, 2025

No description provided.

@tarekgh tarekgh requested a review from a team as a code owner January 22, 2025 00:01
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @tommcdon

@tarekgh
Copy link
Member Author

tarekgh commented Jan 22, 2025

@gewarren could you please help review this change? It is just repeated notes. Thanks!

@tarekgh
Copy link
Member Author

tarekgh commented Jan 22, 2025

@noahfalk I am adding some notes to the observable counters to clarify how these should be used. Could you please have a quick look at this part of the change? Thanks!

@learn-build-service-prod
Copy link

Learn Build status updates of commit 12f18b9:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Globalization/CultureInfo.xml ⚠️Warning View Details
xml/System.Diagnostics.Metrics/Meter.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/ObservableCounter`1.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/ObservableUpDownCounter`1.xml ✅Succeeded View

xml/System.Globalization/CultureInfo.xml

  • Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'format' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some code fencing to prevent localization.

Co-authored-by: Genevieve Warren <[email protected]>
@tarekgh tarekgh enabled auto-merge January 22, 2025 01:24
@learn-build-service-prod
Copy link

Learn Build status updates of commit 25be289:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Globalization/CultureInfo.xml ⚠️Warning View Details
xml/System.Diagnostics.Metrics/Meter.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/ObservableCounter`1.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/ObservableUpDownCounter`1.xml ✅Succeeded View

xml/System.Globalization/CultureInfo.xml

  • Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'format' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@tarekgh tarekgh merged commit 601c540 into main Jan 22, 2025
4 checks passed
@tarekgh tarekgh deleted the MiscNotesForLCIDandMetricCounters branch January 22, 2025 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants