Skip to content

Conversation

@dotnet-policy-service
Copy link
Contributor

Please don't squash-merge this PR.

DickBaker and others added 6 commits January 21, 2025 11:06
the current docs are outdated to NRT and confuse quotes
1. variable should be type string? not string
2. uses old-style format string (new would use interpolated syntax)
3. filepath reassignment should use conditional syntax
4. results suggest using single-quote [i.e. char not string], ugh
5. the final returned result is null but demo output shows '' which is factually visually correct but confusingly indistinuishable from "" emptystring

I propose replacement C# code for this Snippet3
Co-authored-by: Genevieve Warren <[email protected]>
Misc notes for LCID deprecation and Metric observable counters report…
@ghost ghost added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Jan 22, 2025
@learn-build-service-prod
Copy link

Learn Build status updates of commit 601c540:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Globalization/CultureInfo.xml ⚠️Warning View Details
.github/policies/mention-owners.yml ✅Succeeded
snippets/csharp/System.IO/Path/ChangeExtension/pathmembers.cs ✅Succeeded View
xml/System.Diagnostics.Metrics/Meter.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/ObservableCounter`1.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/ObservableUpDownCounter`1.xml ✅Succeeded View
xml/System.IO.Pipes/NamedPipeServerStream.xml ✅Succeeded View

xml/System.Globalization/CultureInfo.xml

  • Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'format' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@dotnet-policy-service dotnet-policy-service bot merged commit db1feb0 into live Jan 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. :octocat: auto-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants