Skip to content

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Feb 4, 2025

Contributes to #10183.

(Hide whitespace changes.)

@gewarren gewarren requested review from a team, 333fred and cston as code owners February 4, 2025 01:19
@ghost
Copy link

ghost commented Feb 4, 2025

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 4, 2025
@ghost
Copy link

ghost commented Feb 4, 2025

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link

Learn Build status updates of commit ee11290:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Globalization/CompareInfo.xml ⚠️Warning View Details
xml/System.Globalization/CultureAndRegionInfoBuilder.xml ⚠️Warning View Details
xml/System.Drawing.Design/ToolboxService.xml ✅Succeeded View
xml/System.Drawing.Drawing2D/GraphicsPath.xml ✅Succeeded View
xml/System.Drawing.Imaging/EncoderParameter.xml ✅Succeeded View
xml/System.Drawing/ColorConverter.xml ✅Succeeded View
xml/System.Drawing/Graphics.xml ✅Succeeded View
xml/System.Drawing/Icon.xml ✅Succeeded View
xml/System.Globalization/EastAsianLunisolarCalendar.xml ✅Succeeded View
xml/System.Globalization/NumberFormatInfo.xml ✅Succeeded View
xml/System.IO.Compression/ZipFileExtensions.xml ✅Succeeded View
xml/System.IO.IsolatedStorage/IsolatedStorageFile.xml ✅Succeeded View
xml/System.IO.IsolatedStorage/IsolatedStorageFileStream.xml ✅Succeeded View
xml/System.IO.Packaging/PackagePart.xml ✅Succeeded View
xml/System.IO.Packaging/PackageStore.xml ✅Succeeded View
xml/System.IO.Packaging/PackUriHelper.xml ✅Succeeded View
xml/System.IO.Pipes/NamedPipeServerStream.xml ✅Succeeded View
xml/System.IO.Pipes/PipeStream.xml ✅Succeeded View
xml/System.IO/BufferedStream.xml ✅Succeeded View
xml/System.IO/Directory.xml ✅Succeeded View
xml/System.IO/DirectoryInfo.xml ✅Succeeded View
xml/System.IO/FileStream.xml ✅Succeeded View
xml/System.IO/FileStreamOptions.xml ✅Succeeded View
xml/System.IO/MemoryStream.xml ✅Succeeded View
xml/System.IO/Stream.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.

xml/System.Globalization/CompareInfo.xml

  • Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'format' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

xml/System.Globalization/CultureAndRegionInfoBuilder.xml

  • Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'format' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@gewarren gewarren merged commit 7f6af85 into dotnet:main Feb 4, 2025
4 checks passed
@gewarren gewarren deleted the paramrefs0203 branch February 4, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants