Skip to content

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Feb 4, 2025

Fixes #10895
Contributes to #10183
(Hide whitespace changes.)

@gewarren gewarren requested a review from a team as a code owner February 4, 2025 02:59
@ghost ghost added the area-System.Net label Feb 4, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl

Copy link

Learn Build status updates of commit 11bad29:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Http.Headers/HttpHeaders.xml ✅Succeeded View
xml/System.Net.Mail/Attachment.xml ✅Succeeded View
xml/System.Net.Mail/SmtpClient.xml ✅Succeeded View
xml/System.Net.NetworkInformation/GatewayIPAddressInformationCollection.xml ✅Succeeded View
xml/System.Net.NetworkInformation/MulticastIPAddressInformationCollection.xml ✅Succeeded View
xml/System.Net.NetworkInformation/PhysicalAddress.xml ✅Succeeded View
xml/System.Net.NetworkInformation/Ping.xml ✅Succeeded View
xml/System.Net.NetworkInformation/UnicastIPAddressInformationCollection.xml ✅Succeeded View
xml/System.Net.PeerToPeer.Collaboration/PeerContact.xml ✅Succeeded View
xml/System.Net.Security/NegotiateStream.xml ✅Succeeded View
xml/System.Net.Security/SslStream.xml ✅Succeeded View
xml/System.Net.Sockets/IPv6MulticastOption.xml ✅Succeeded View
xml/System.Net.Sockets/MulticastOption.xml ✅Succeeded View
xml/System.Net.Sockets/NetworkStream.xml ✅Succeeded View
xml/System.Net.Sockets/Socket.xml ✅Succeeded View
xml/System.Net.Sockets/SocketTaskExtensions.xml ✅Succeeded View
xml/System.Net.Sockets/TcpClient.xml ✅Succeeded View
xml/System.Net.Sockets/UdpClient.xml ✅Succeeded View
xml/System.Net/CookieContainer.xml ✅Succeeded View
xml/System.Net/CredentialCache.xml ✅Succeeded View
xml/System.Net/HttpListenerRequest.xml ✅Succeeded View
xml/System.Net/HttpWebRequest.xml ✅Succeeded View
xml/System.Net/IPAddress.xml ✅Succeeded View
xml/System.Net/SocketAddress.xml ✅Succeeded View
xml/System.Net/WebClient.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren requested a review from BillWagner February 7, 2025 16:24
Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@gewarren gewarren merged commit 0a98f0c into dotnet:main Feb 12, 2025
4 checks passed
@gewarren gewarren deleted the paramrefs-system.net branch February 12, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reference to wrong parameter name "size": should be "count"

2 participants