Merge main into live #11046
Merged
Merge main into live #11046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-policy-service[bot]](https://avatars.githubusercontent.com/in/285228?s=80&v=4){kind=small}
These samples were not handling the `asyncResult.CompletedSynchronously == true` case correctly: changing the sample code to use smaller buffer leads to stack overflow because of recursion on synchronous completions. Besides the fix there the PR adds some consolidation: - Cleanup and (somewhat) modernize the sample code - Remove the Timer-based custom timeout implementation, use `WebRequest.Timeout` instead - Collapse various samples into one sample - Unifiy the `HttpWebRequest` and `WebRequest` samples since they are practically identical - Delete CPP and VB samples given we don't have the capacity and the intention to maintain them.
ghost
added
the
area-Meta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-Meta
Concerns something that extends across runtime area boundaries, for example, IDisposable.
auto-merge
auto-merge
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't squash-merge this PR.