Skip to content

Fix mismatched paramrefs (System.Security*) #11147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2025
Merged

Fix mismatched paramrefs (System.Security*) #11147

merged 2 commits into from
Apr 8, 2025

Conversation

gewarren
Copy link
Contributor

Contributes to #10183.

(Hide whitespace changes.)

@gewarren gewarren requested a review from a team as a code owner March 28, 2025 21:16
@github-actions github-actions bot added the area-System.Security Issues related to security practices for .NET developers. label Mar 28, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 5dbe1dc:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Security.AccessControl/CompoundAce.xml ✅Succeeded View
xml/System.Security.AccessControl/CustomAce.xml ✅Succeeded View
xml/System.Security.AccessControl/FileSecurity.xml ✅Succeeded View
xml/System.Security.AccessControl/GenericAce.xml ✅Succeeded View
xml/System.Security.AccessControl/GenericAcl.xml ✅Succeeded View
xml/System.Security.AccessControl/GenericSecurityDescriptor.xml ✅Succeeded View
xml/System.Security.AccessControl/ObjectAce.xml ✅Succeeded View
xml/System.Security.AccessControl/ObjectAuditRule.xml ✅Succeeded View
xml/System.Security.AccessControl/RawAcl.xml ✅Succeeded View
xml/System.Security.AccessControl/RegistryAccessRule.xml ✅Succeeded View
xml/System.Security.Authentication.ExtendedProtection/ServiceNameCollection.xml ✅Succeeded View
xml/System.Security.Cryptography.Cose/CoseHeaderMap.xml ✅Succeeded View
xml/System.Security.Cryptography.Pkcs/CmsRecipient.xml ✅Succeeded View
xml/System.Security.Cryptography.Pkcs/ContentInfo.xml ✅Succeeded View
xml/System.Security.Cryptography.Pkcs/Pkcs12KeyBag.xml ✅Succeeded View
xml/System.Security.Cryptography.Pkcs/Pkcs12ShroudedKeyBag.xml ✅Succeeded View
xml/System.Security.Cryptography.Pkcs/Pkcs9AttributeObject.xml ✅Succeeded View
xml/System.Security.Cryptography.X509Certificates/CertificateRequest.xml ✅Succeeded View
xml/System.Security.Cryptography.X509Certificates/X509Certificate.xml ✅Succeeded View
xml/System.Security.Cryptography.X509Certificates/X509CertificateCollection.xml ✅Succeeded View
xml/System.Security.Cryptography.Xml/CipherData.xml ✅Succeeded View
xml/System.Security.Cryptography.Xml/EncryptedXml.xml ✅Succeeded View
xml/System.Security.Cryptography/CryptographicAttributeObjectCollection.xml ✅Succeeded View
xml/System.Security.Cryptography/CryptoStream.xml ✅Succeeded View
xml/System.Security.Cryptography/DpapiDataProtector.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

BillWagner
BillWagner approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also LGTM @gewarren

Let's :shipit:

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit d76a521:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Security.AccessControl/CompoundAce.xml ✅Succeeded View
xml/System.Security.AccessControl/CustomAce.xml ✅Succeeded View
xml/System.Security.AccessControl/FileSecurity.xml ✅Succeeded View
xml/System.Security.AccessControl/GenericAce.xml ✅Succeeded View
xml/System.Security.AccessControl/GenericAcl.xml ✅Succeeded View
xml/System.Security.AccessControl/GenericSecurityDescriptor.xml ✅Succeeded View
xml/System.Security.AccessControl/ObjectAce.xml ✅Succeeded View
xml/System.Security.AccessControl/ObjectAuditRule.xml ✅Succeeded View
xml/System.Security.AccessControl/RawAcl.xml ✅Succeeded View
xml/System.Security.AccessControl/RegistryAccessRule.xml ✅Succeeded View
xml/System.Security.Authentication.ExtendedProtection/ServiceNameCollection.xml ✅Succeeded View
xml/System.Security.Cryptography.Cose/CoseHeaderMap.xml ✅Succeeded View
xml/System.Security.Cryptography.Pkcs/CmsRecipient.xml ✅Succeeded View
xml/System.Security.Cryptography.Pkcs/ContentInfo.xml ✅Succeeded View
xml/System.Security.Cryptography.Pkcs/Pkcs12KeyBag.xml ✅Succeeded View
xml/System.Security.Cryptography.Pkcs/Pkcs12ShroudedKeyBag.xml ✅Succeeded View
xml/System.Security.Cryptography.Pkcs/Pkcs9AttributeObject.xml ✅Succeeded View
xml/System.Security.Cryptography.X509Certificates/CertificateRequest.xml ✅Succeeded View
xml/System.Security.Cryptography.X509Certificates/X509Certificate.xml ✅Succeeded View
xml/System.Security.Cryptography.X509Certificates/X509CertificateCollection.xml ✅Succeeded View
xml/System.Security.Cryptography.Xml/CipherData.xml ✅Succeeded View
xml/System.Security.Cryptography.Xml/EncryptedXml.xml ✅Succeeded View
xml/System.Security.Cryptography/CryptographicAttributeObjectCollection.xml ✅Succeeded View
xml/System.Security.Cryptography/CryptoStream.xml ✅Succeeded View
xml/System.Security.Cryptography/DpapiDataProtector.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit 858e24b into dotnet:main Apr 8, 2025
4 checks passed
@gewarren gewarren deleted the mismatched-paramrefs-system.security branch April 8, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees

@gewarren gewarren

Labels
area-System.Security Issues related to security practices for .NET developers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gewarren @BillWagner