Skip to content

Conversation

gewarren
Copy link
Contributor

No description provided.

@gewarren gewarren requested a review from a team as a code owner April 25, 2025 02:16
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 25, 2025
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, with one suggestion. Let's :shipit:

@@ -75,7 +75,7 @@ static void Main(string[] args)
double dxD = trpz.GetLeftBaseDegreeAngle();
Console.WriteLine("Trapezoid left base angle is: " + dxD.ToString() + " Degrees");
double dyD = trpz.GetRightBaseDegreeAngle();
Console.WriteLine("Trapezoid left base angle is: " + dyD.ToString() + " Degrees");
Console.WriteLine("Trapezoid right base angle is: " + dyD.ToString() + " Degrees");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While here, should we use string interpolation:

Suggested change
Console.WriteLine("Trapezoid right base angle is: " + dyD.ToString() + " Degrees");
Console.WriteLine($"Trapezoid right base angle is: {dyD} Degrees");

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I change this one, I should change all of them. Is it okay to put this off until we do a bulk effort to update string formats?

@gewarren gewarren merged commit 6a6f5c7 into dotnet:main Apr 28, 2025
4 of 5 checks passed
@gewarren gewarren deleted the trapezoid branch April 28, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners user-feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants