Skip to content

Fix incorrect ThreeLetterWindowsLanguageName example for zh-Hant (CHT -> ZHH) #11472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 20, 2025
Merged

Fix incorrect ThreeLetterWindowsLanguageName example for zh-Hant (CHT -> ZHH) #11472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f62abb1
Initial plan for issue
Copilot Jun 19, 2025
bde6dad
Fix incorrect ThreeLetterWindowsLanguageName example for zh-Hant (CHT…
Copilot Jun 19, 2025
ac7824b
Verify and fix all culture codes in documentation examples - confirme…
Copilot Jun 19, 2025
7b4f79e
Fix spacing inconsistencies in culture code examples
Copilot Jun 19, 2025
48fe208
Fix spacing in VB file line 43 to align with reference pattern
Copilot Jun 19, 2025
e31b1d1
Remove zh-CHS and zh-CHT from neutral cultures example - these legacy…
Copilot Jun 19, 2025
3e3ca32
Fix writing style and culture ordering issues - change 'may' to 'migh…
Copilot Jun 19, 2025
ce61510
Add comment explaining zh-Hant ICU vs NLS behavior difference
Copilot Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions snippets/csharp/System.Globalization/CultureInfo/DisplayName/getcultures.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ CULTURE ISO ISO WIN DISPLAYNAME ENGLISHNAME
ar ar ara ARA Arabic Arabic
bg bg bul BGR Bulgarian Bulgarian
ca ca cat CAT Catalan Catalan
zh-Hans zh zho CHS Chinese (Simplified) Chinese (Simplified)
cs cs ces CSY Czech Czech
da da dan DAN Danish Danish
de de deu DEU German German
Expand All @@ -41,9 +40,10 @@ en en eng ENU English English
es es spa ESP Spanish Spanish
fi fi fin FIN Finnish Finnish
zh zh zho CHS Chinese Chinese
zh-Hant zh zho CHT Chinese (Traditional) Chinese (Traditional)
zh-CHS zh zho CHS Chinese (Simplified) Legacy Chinese (Simplified) Legacy
zh-CHT zh zho CHT Chinese (Traditional) Legacy Chinese (Traditional) Legacy
zh-Hans zh zho CHS Chinese (Simplified) Chinese (Simplified)
zh-Hant zh zho ZHH Chinese (Traditional) Chinese (Traditional)

Note: zh-Hant returns ZHH when using ICU (default). When NLS mode is enabled, it returns CHT.

*/
// </snippet1>
8 changes: 4 additions & 4 deletions ...sic/VS_Snippets_CLR_System/system.Globalization.CultureInfo.GetCultures/VB/getcultures.vb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
' The following code example displays several properties of the neutral cultures.

' <snippet1>
Expand Down Expand Up @@ -29,7 +29,6 @@
'ar ar ara ARA Arabic Arabic
'bg bg bul BGR Bulgarian Bulgarian
'ca ca cat CAT Catalan Catalan
'zh-Hans zh zho CHS Chinese (Simplified) Chinese (Simplified)
'cs cs ces CSY Czech Czech
'da da dan DAN Danish Danish
'de de deu DEU German German
Expand All @@ -38,9 +37,10 @@
'es es spa ESP Spanish Spanish
'fi fi fin FIN Finnish Finnish
'zh zh zho CHS Chinese Chinese
'zh-Hant zh zho CHT Chinese (Traditional) Chinese (Traditional)
'zh-CHS zh zho CHS Chinese (Simplified) Legacy Chinese (Simplified) Legacy
'zh-CHT zh zho CHT Chinese (Traditional) Legacy Chinese (Traditional) Legacy
'zh-Hans zh zho CHS Chinese (Simplified) Chinese (Simplified)
'zh-Hant zh zho ZHH Chinese (Traditional) Chinese (Traditional)
'
'Note: zh-Hant returns ZHH when using ICU (default). When NLS mode is enabled, it returns CHT.

End Module
' </snippet1>
2 changes: 1 addition & 1 deletion xml/System.Globalization/CultureInfo.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3378,7 +3378,7 @@ The following code example shows that CultureInfo.Clone also clones the <xref:Sy
The following code example displays several properties of the neutral cultures.

> [!NOTE]
> The example displays the older `zh-CHS` and `zh-CHT` culture names with the 0x0004 and 0x7C04 culture identifiers, respectively. However, your Windows Vista applications should use the `zh-Hans` name instead of zh-CHS and the `zh-Hant` name instead of zh-CHT. The `zh-Hans` and `zh-Hant` names represent the current standard, and should be used unless you have a reason for using the older names.
> The `zh-Hans` and `zh-Hant` names represent the current standard for Chinese cultures. Older applications might reference the legacy `zh-CHS` and `zh-CHT` culture names, but these should be replaced with `zh-Hans` and `zh-Hant` respectively in modern applications.

:::code language="csharp" source="~/snippets/csharp/System.Globalization/CultureInfo/DisplayName/getcultures.cs" id="Snippet1":::
:::code language="vb" source="~/snippets/visualbasic/VS_Snippets_CLR_System/system.Globalization.CultureInfo.GetCultures/VB/getcultures.vb" id="Snippet1":::
Expand Down
Loading