Skip to content

Conversation

PopSlime
Copy link
Contributor

@PopSlime PopSlime commented Aug 4, 2025

Summary

The Single.Parse, Single.TryParse, Double.Parse, and Double.TryParse methods are case-insensitive in .NET Core 3.0 and later, when parsing string representations of PositiveInfinity, NegativeInfinity, and NaN.

References

@PopSlime PopSlime requested a review from a team as a code owner August 4, 2025 13:32
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 4, 2025
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a suggestion to try and make it more clear that all of the symbols are compared case insensitively.

@gewarren gewarren requested a review from tannergooding August 4, 2025 17:17
@tannergooding
Copy link
Member

Changes overall LGTM, but it looks like the suggestions from @gewarren still need to be taken and the latter suggestion should be applied to all the similar places. That is, ensuring they use a separate sentence of the same form rather than putting the information in parentheses.

@PopSlime PopSlime requested a review from gewarren August 28, 2025 04:47
@gewarren gewarren enabled auto-merge (squash) August 28, 2025 16:31
@gewarren gewarren merged commit 510273a into dotnet:main Aug 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Runtime community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants