Skip to content

Conversation

@jeffhandley
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings November 19, 2025 02:03
@jeffhandley jeffhandley requested a review from a team as a code owner November 19, 2025 02:03
@github-actions github-actions bot added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Nov 19, 2025
Copilot finished reviewing on behalf of jeffhandley November 19, 2025 02:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds security documentation notes about handling untrusted data across various System.Speech API documentation files. The changes use include files to provide consistent warnings about security considerations when working with external data sources.

  • Adds untrusted data warnings to speech synthesis and recognition classes
  • Replaces existing security guidance with standardized include notes
  • Applies appropriate note types (class-level, instance-level, and interface-level warnings)

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
xml/System.Speech.Synthesis/SpeechSynthesizer.xml Adds class-level untrusted data warnings for lexicon-related methods
xml/System.Speech.Synthesis/PromptBuilder.xml Adds class-level untrusted data warnings for prompt building methods
xml/System.Speech.Synthesis/FilePrompt.xml Adds instance-level untrusted data warnings to class and constructor documentation
xml/System.Speech.Synthesis.TtsEngine/TtsEngineSsml.xml Adds class-level untrusted data warnings for AddLexicon and RemoveLexicon methods
xml/System.Speech.Synthesis.TtsEngine/ITtsEngineSite.xml Adds interface-level untrusted data warning to LoadResource method
xml/System.Speech.Recognition/Grammar.xml Replaces existing security guidance with instance-level untrusted data warnings across multiple constructors
xml/System.Speech.Recognition.SrgsGrammar/SrgsRuleRef.xml Adds instance-level untrusted data warnings to class and multiple constructors
xml/System.Speech.Recognition.SrgsGrammar/SrgsDocument.xml Adds instance-level untrusted data warning to XmlBase property documentation

@jeffhandley jeffhandley requested a review from gewarren November 19, 2025 05:18
Copy link

@pranav-gupta-msft pranav-gupta-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffhandley jeffhandley enabled auto-merge (squash) November 19, 2025 20:22
@jeffhandley jeffhandley merged commit f321970 into dotnet:main Nov 19, 2025
6 checks passed
@jeffhandley jeffhandley deleted the jeffhandley/untrusted-speech-inputs branch November 19, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants