Skip to content

Add security warning to ArrayPool.Return documentation #12062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 20, 2025
+3 −0
Merged

Add security warning to ArrayPool.Return documentation #12062

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2034d04
Initial plan
Copilot Nov 20, 2025
7d5fa4d
Add security note to ArrayPool.Return documentation
Copilot Nov 20, 2025
967877b
Update xml/System.Buffers/ArrayPool`1.xml
jkotas Nov 20, 2025
bbef604
Add Oxford comma to security warning list
Copilot Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions xml/System.Buffers/ArrayPool`1.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,9 @@ The array returned by this method may not be zero-initialized.
## Remarks
Once a buffer has been returned to the pool, the caller gives up all ownership of the buffer and must not use it. The reference returned from a given call to the <xref:System.Buffers.ArrayPool%601.Rent%2A> method must only be returned using the <xref:System.Buffers.ArrayPool%601.Return%2A> method once. The default <xref:System.Buffers.ArrayPool%601> may hold onto the returned buffer in order to rent it again, or it may release the returned buffer if it's determined that the pool already has enough buffers stored.
> [!IMPORTANT]
> Returning the same array reference twice or continuing to use the array reference after it has been returned is a high-severity security issue. These actions can lead to [double-free](https://cwe.mitre.org/data/definitions/415.html) and [use-after-free](https://cwe.mitre.org/data/definitions/416.html) vulnerabilities, which might result in data corruption, data leaks, and denial of service.
]]></format>
</remarks>
</Docs>
Expand Down