Add links to specific overloads of ZipFileExtensions #2282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed links to point to specific overloads of ZipFileExtensions.CreateEntryFromFile
rpetrusha
added
the
✨ 1st-time dotnet-api-docs contributor!
rpetrusha
suggested changes
Apr 10, 2019
There was a problem hiding this comment.
Thank you, @devrathnd, for contributing to the dotnet/docs repo. Changing these xrefs to link to a specific overload of ZipExtensions is definitely helpful. However, there are actually four extension methods: ExtractToDirectory is overloaded, with a new overload available starting with .NET Core 2.0. I've suggested a change to the paragraph.
Co-Authored-By: devrathnd <[email protected]>
rpetrusha
approved these changes
Apr 11, 2019
|
Thanks, @devrathnd, for making the additional changes. We'll merge your PR now. The updated documentation should appear on docs.microsoft.com in the next day or two. |
|
Thank you @rpetrusha :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed links to point to specific overloads of ZipFileExtensions.CreateEntryFromFile
Summary
Changed links to point to specific overloads of ZipFileExtensions.CreateEntryFromFile in the section that talks about the three extension methods for the ZipArchive Class.