Skip to content

fix: Underscore astoria snippets #2291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 12, 2019

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Apr 11, 2019

Related to dotnet/samples#810

@nschonni nschonni requested a review from stevestein as a code owner April 11, 2019 21:12
@nschonni nschonni changed the title fix: Underscore "astoria quickstart service" fix: Underscore astoria snippets Apr 11, 2019
@rpetrusha
Copy link

Closing and reopening to begin new build.

@rpetrusha rpetrusha closed this Apr 11, 2019
@rpetrusha rpetrusha reopened this Apr 11, 2019
@rpetrusha
Copy link

There are also four broken code references in this PR, @nschonni. See the build report.

@mairaw mairaw closed this Apr 11, 2019
@mairaw mairaw reopened this Apr 11, 2019
@mairaw
Copy link
Contributor

mairaw commented Apr 12, 2019

Restarting build after I merged the latest PR

@nschonni
Copy link
Contributor Author

@mairaw looks like this one is OK now

@mairaw
Copy link
Contributor

mairaw commented Apr 12, 2019

Yes!

@mairaw mairaw merged commit 53a980a into dotnet:master Apr 12, 2019
@mairaw mairaw added this to the April 2019 milestone Apr 12, 2019
@nschonni nschonni deleted the underscore-astoria-snippets branch April 12, 2019 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants