Skip to content

Port two exceptions from System.Linq triple slash comments to Docs #2320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2019

Conversation

carlossanlop
Copy link
Contributor

Summary

Found a couple of exceptions that were mentioned in the source code triple slash comments of System.Linq but were not yet in dotnet-api-docs. Seemed important since they describe two obsolete functions that should always throw when called.

Fixes #Issue_Number (if available)

@carlossanlop
Copy link
Contributor Author

@mairaw @rpetrusha Please take a look whenever possible.

Adding the area owner @maryamariyan in case there are any additional comments or suggestions.

Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these exceptions, @carlossanlop. Could you remove the other documented exceptions for these two method overloads? This is evidently a copy and paste error; nothing other than a NotSupportedException can actually be thrown.

@mairaw mairaw added this to the April 2019 milestone Apr 17, 2019
@mairaw mairaw merged commit c4204c6 into dotnet:master Apr 25, 2019
@mairaw mairaw added the doc-update Update outdated articles label Apr 25, 2019
@carlossanlop carlossanlop deleted the linq branch April 25, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants