Skip to content

Port triple slash comment from System.IO to Docs #2321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2019

Conversation

carlossanlop
Copy link
Contributor

Summary

Automatically porting a comment found in System.IO.FileSystemInfo source code triple slash comments that did not exist in dotnet-api-docs. I also took the liberty to manually add a return value since it was missing as well.

Fixes #Issue_Number (if available)

@carlossanlop
Copy link
Contributor Author

@mairaw @rpetrusha please take a look whenever possible.

Adding the area owner @JeremyKuhne in case he has any additional comments or suggestions.

@mairaw mairaw added this to the April 2019 milestone Apr 17, 2019
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting the new member, @carlossanlop. I've left two suggested changes for you to consider.

Suggestions from rpetrusha

Co-Authored-By: carlossanlop <[email protected]>
@mairaw mairaw added changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review new-content Indicates PRs that contain new articles 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 labels Apr 27, 2019
@rpetrusha
Copy link

Thanks, @carlossanlop. I'll merge now.

@rpetrusha rpetrusha merged commit 936cbb7 into dotnet:master May 2, 2019
@carlossanlop carlossanlop deleted the systemio branch May 2, 2019 16:34
@mairaw mairaw removed the changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review label Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants