Port System.ComponentModel.Composition source code comments to Docs #2324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mairaw @rpetrusha please take a look whenever you get a chance. |
maryamariyan
approved these changes
Apr 25, 2019
safern
reviewed
Apr 25, 2019
xml/System.ComponentModel.Composition/CompositionContractMismatchException.xml
Show resolved
Hide resolved
safern
approved these changes
Apr 25, 2019
rpetrusha
suggested changes
Apr 26, 2019
There was a problem hiding this comment.
Thanks for adding exception information, @carlossanlop. I've left some suggestions for you to consider.
xml/System.ComponentModel.Composition/AttributedModelServices.xml
Outdated
Show resolved
Hide resolved
xml/System.ComponentModel.Composition/AttributedModelServices.xml
Outdated
Show resolved
Hide resolved
xml/System.ComponentModel.Composition/AttributedModelServices.xml
Outdated
Show resolved
Hide resolved
xml/System.ComponentModel.Composition/AttributedModelServices.xml
Outdated
Show resolved
Hide resolved
Suggestions by rpetrusha Co-Authored-By: carlossanlop <[email protected]>
mairaw
added
changes-addressed
|
@rpetrusha I think I addressed all the suggestions. Any chance we can merge this? |
rpetrusha
approved these changes
May 1, 2019
|
Yes, I'll merge it now, @carlossanlop. Thanks for making the additional changes. |
mairaw
removed
the
changes-addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Automatically ported exceptions found in triple slash source code comments in System.ComponentModel.Composition that did not exist in dotnet-api-docs.
Fixes #Issue_Number (if available)