Skip to content

Added documentation for DataflowBlockOptions.EnsureOrdered #2374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2019
Merged

Added documentation for DataflowBlockOptions.EnsureOrdered #2374

merged 2 commits into from
Apr 29, 2019

Conversation

svick
Copy link
Contributor

@svick svick commented Apr 28, 2019

Fixes #2373.

The text was copied from XML documentation on the source code.

@svick svick mentioned this pull request Apr 28, 2019
Closed
rpetrusha
rpetrusha reviewed Apr 29, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @svick, for addressing #2373. I've suggested some changes for you to review.

rpetrusha
rpetrusha suggested changes Apr 29, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, @svick. I'd meant to request changes rather than simply comment.

@rpetrusha rpetrusha added this to the May 2019 milestone Apr 29, 2019
@svick
Copy link
Contributor Author

svick commented Apr 29, 2019

@rpetrusha Thanks, I have applied your changes.

@mairaw mairaw added the changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review label Apr 29, 2019
@rpetrusha
Copy link

Thanks for making the additional changes, @svick. I'll merge your PR now.

@rpetrusha rpetrusha merged commit 50bdcbf into dotnet:master Apr 29, 2019
@svick svick deleted the patch-1 branch April 29, 2019 23:28
@mairaw mairaw removed the changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review label Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@svick svick

Labels
None yet
Projects
None yet
Milestone
May 2019
Development

Successfully merging this pull request may close these issues.

Does the default value of the DataflowBlockOptions.EnsureOrdered property is true?
3 participants
@svick @rpetrusha @mairaw