CI Update - .NET Core 3.0 Preview 4 #2386
Conversation
| @@ -98,7 +98,7 @@ | |||
| <AssemblyName>System.Core</AssemblyName> | |||
| </AssemblyInfo> | |||
| <Attributes> | |||
| <Attribute FrameworkAlternate="netcore-2.0;netcore-2.1;netcore-2.2;netcore-3.0"> | |||
| <Attribute FrameworkAlternate="netcore-2.0;netcore-2.1;netcore-2.2"> | |||
There was a problem hiding this comment.
It does indeed. @joelmartinez can you check if this is expected? If not, I can open a bug.
There was a problem hiding this comment.
offhand, no I'm not sure why this occurred ... yes a bug would be ideal
| @@ -35,7 +35,7 @@ | |||
| </ReturnValue> | |||
| <Parameters> | |||
| <Parameter Name="reader" Type="System.Buffers.SequenceReader<System.Byte>" RefType="this" /> | |||
| <Parameter Name="value" Type="System.Int64" RefType="out" /> | |||
| <Parameter Name="value" Type="System.Int16" RefType="out" /> | |||
There was a problem hiding this comment.
The changes in this file look problematic. There should be three overloads of TryReadLittleEndian and TryReadBigEndian. They're distinguished by their out parameters: Int16, Int32, and Int64.
There was a problem hiding this comment.
This is a "known" issue but I'm not sure if we have a bug tracking these APIs. @joelmartinez can you confirm if you have a tracking bug for this? I couldn't find it on https://github.com/mono/api-doc-tools
There was a problem hiding this comment.
@mairaw no I'm not sure I had seen this issue before … hmm, so the issue is that there's three overloads in the actual assemblies, but the EcmaXml only shows one (and the type is being updated in this latest update?)
No description provided.