Fix altMembers that Build is not able to resolve #2430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mairaw
requested changes
May 10, 2019
There was a problem hiding this comment.
Thanks @TianqiZhang for making these fixes. I left some suggestions for you to address.
Those were hard to spot because OPS doesn't give us any warnings when they are broken.
Co-Authored-By: Maira Wenzel <[email protected]>
|
Thanks @mairaw , files updated :) |
BillWagner
added
the
changes-addressed
mairaw
approved these changes
May 13, 2019
mairaw
removed
the
changes-addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found these when doing diff comparing for SDP change. It seems the best way is to fix the content directly instead of making workarounds in code.