Document PlatformNotSupportedExceptions in System.Console #2433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding @rpetrusha @mairaw. Can you please take a look? |
xml/System/Console.xml
Outdated
| @@ -3314,6 +3328,8 @@ | |||
|
|
|||
| As a result of the assignment, <see cref="P:System.Console.WindowLeft" /> plus <see cref="P:System.Console.WindowWidth" /> would exceed <see cref="P:System.Console.BufferWidth" />.</exception> | |||
| <exception cref="T:System.IO.IOException">Error reading or writing information.</exception> | |||
| <exception cref="T:System.PlatformNotSupportedException">The set operation is invoked on an operating system other than Windows.</exception> | |||
|
|
|||
There was a problem hiding this comment.
nit: Extra space:
Suggested change
|
Looks good to me. I left a nit comment. Let's wait for the Docs team review so they can merge it. |
rpetrusha
approved these changes
May 10, 2019
There was a problem hiding this comment.
Thanks for adding these changes, @wtgodbe. I've addressed the suggestion from @carlossanlop. I've approved your PR, and I'll merge when the build completes successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Several members of
System.ConsolethrowPlatformNotSupportedExceptionson Non-Windows. This wasn't previously documented.CC @calope