Skip to content

add reference to new samples #2436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2019
Merged

add reference to new samples #2436

merged 2 commits into from
May 15, 2019

Conversation

dsychin
Copy link
Contributor

@dsychin dsychin commented May 11, 2019

Fixes #796
Requires dotnet/samples#896

Added reference to new sample and change explanation of each example.

@BillWagner BillWagner requested a review from rpetrusha May 13, 2019 15:08
@rpetrusha
Copy link

Closing and reopening to begin new build.

@rpetrusha rpetrusha closed this May 13, 2019
@rpetrusha rpetrusha reopened this May 13, 2019
@rpetrusha rpetrusha added verify-build-before-merge 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) and removed verify-build-before-merge labels May 13, 2019
@rpetrusha rpetrusha added this to the May 2019 milestone May 13, 2019
@rpetrusha
Copy link

Closing and reopening to begin new build after dotnet/samples#898 was merged.

@rpetrusha rpetrusha closed this May 15, 2019
@rpetrusha rpetrusha reopened this May 15, 2019
rpetrusha
rpetrusha approved these changes May 15, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding your examples to the documentation, @dsychin. I'll merge your PR now. The examples should be live on docs.microsoft.com in the next day or two.

@rpetrusha rpetrusha merged commit 8929abb into dotnet:master May 15, 2019
@mairaw mairaw removed the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label May 15, 2019
@dsychin dsychin deleted the copy-directory branch May 16, 2019 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@dsychin dsychin

Labels
None yet
Projects
None yet
Milestone
May 2019
Development

Successfully merging this pull request may close these issues.

All of the examples on the FileSystem.CopyDirectory are the same. Please make relevent examples.
3 participants
@dsychin @rpetrusha @mairaw