make descriptions uniform + add exceptions #2442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
approved these changes
Dec 12, 2019
There was a problem hiding this comment.
@mairaw will you get a chance to address Ron's suggestions to improve the accuracy of the sentences? He approved (and just in case his approval is not valid anymore, I'll approve it too).
|
@vatsan-madhavan @amit-kabra Maira pointed out these are WPF owned changes. Can you please review them? |
SamBent
suggested changes
Dec 12, 2019
|
@mairaw Do you want me to take this PR over and get it merged? |
|
Yes, that would be great @gewarren |
|
@BillWagner Is it okay if I take this one? |
gewarren
reviewed
Jul 8, 2020
|
|
||
| ]]></format> | ||
| </remarks> | ||
| <returns>The value returned by <paramref name="callback" />.</returns> |
There was a problem hiding this comment.
@SamBent Can you verify that this return value is correct? It looks like it was incorrectly placed in the Remarks before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2409
@OliaG @SamBent who can review this change for WPF docs?