Updated culture-sensitive formatting information #2463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpetrusha
added
the
🚧 Hold for related PR
BillWagner
approved these changes
May 20, 2019
There was a problem hiding this comment.
This LGTM @rpetrusha
I had one observation, but I thought your change was what you intended.
you can 
when ready.
xml/System/DateTime.xml
Outdated
| > [!NOTE] | ||
| > The string returned by the <xref:System.DateTime.ToShortDateString%2A> method is culture-sensitive. It reflects the pattern defined by the current culture's <xref:System.Globalization.DateTimeFormatInfo.ToShortDateString?displayProperty=nameWithType> method. For example, for the en-US culture, the standard short date pattern is "M/d/yyyy"; for the de-DE culture, it is "dd.MM.yyyy"; for the ja-JP culture, it is "yyyy/MM/dd". Note that its value can vary depending on the .NET implementation and its version, the operating system and its version, and user customization. | ||
|
|
||
| [!INCLUDE[japanese-era-note](~/includes/calendar-era.md)] |
There was a problem hiding this comment.
I see that this is a different include than the one you added above. I think that is what you meant, but I wanted to point it out
There was a problem hiding this comment.
Thanks for catching this, @BillWagner! This is a copy-and-paste error; I'd in fact meant to link to the new include file that I added in this PR.
xml/System/DateTime.xml
Outdated
| > [!NOTE] | ||
| > The string returned by the <xref:System.DateTime.ToShortTimeString%2A> method is culture-sensitive. It reflects the pattern defined by the current culture's <xref:System.Globalization.DateTimeFormatInfo.ShortTimePattern?displayProperty=nameWithType> property. For example, for the en-US culture, the standard short time pattern is "h:mm tt"; for the de-DE culture, it is "HH:mm"; for the ja-JP culture, it is "H:mm". Note that its value can vary depending on the .NET implementation and its version, the operating system and its version, and user customization. | ||
|
|
||
| [!INCLUDE[japanese-era-note](~/includes/calendar-era.md)] |
mairaw
removed
the
🚧 Hold for related PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated culture-sensitive formatting information
This PR:
Related to #2455
Depends on dotnet/samples#917