Skip to content

Conversation

carlossanlop
Copy link
Contributor

Automatically port triple slash comments found in System.Text.Json to dotnet-api-docs.

Second attempt - The first PR got in a bad state (unresolvable conflicts) because several APIs in this namespace got changed. This PR now contains the most up-to-date API versions.

@carlossanlop
Copy link
Contributor Author

Adding area owners @ahsonkhan@steveharter for review.

@mairaw @rpetrusha for language review.

Please take a look whenever you get a chance.

I added some logic to the porting tool so it could automatically resolve the spacing issues we had last time. Let me know if you still see some inconsistencies.

@rpetrusha rpetrusha added this to the May 2019 milestone May 20, 2019
@mairaw mairaw added new-content Indicates PRs that contain new articles 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 labels May 21, 2019
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left two comments, @carlossanlop -- I don't think that the remarks for the two dispose methods are accurate. I've also incorporated all of my edits into your json branch, so it would be a good idea to review my two commits.

@carlossanlop
Copy link
Contributor Author

carlossanlop commented May 23, 2019

@rpetrusha I reviewed your two commits, thanks for doing those changes.

Can we incorporate the contents of your review #2422 into this one? I think my tool did not catch those modifications in this PR, but the easiest thing to do is to merge it all at once here. I'll let you decide, let me know and I'll submit the modification.

Edit: Nevermind, I see you already merged it.

@carlossanlop
Copy link
Contributor Author

@rpetrusha This one's ready. Ahson confirmed the remarks are correct.

@rpetrusha
Copy link

Thanks, @carlossanlop. I'll merge now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants