-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update File.xml #2526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update File.xml #2526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @kaloyankrastev, for contributing to the dotnet/dotnet-api-docs repo and adding the missing exception information. I've suggested a slight change to one of the exception conditions.
If you're planning to open a PR to address a problem you've noticed in the documentation, the extra step of creating an issue before hand is not necessary; you can just submit the PR.
Again, thanks for your contribution. We appreciate it.
Co-Authored-By: Ron Petrusha <[email protected]>
Hi @rpetrusha, Again, thanks for taking my suggestions into account! |
Try closing/reopening pull request, it should trigger build. |
Thanks for making the additional change, @kaloyankrastev. Your closing and reopening your PR did trigger a new build, which looks good. I'll approve and merge now. The changes should be live on docs.microsoft.com in the next day or two. |
Summary
Include missing possible exceptions that might be thrown in some System.IO.File methods.
Fixes #2525