Skip to content

Conversation

kaloyankrastev
Copy link
Contributor

Summary

Include missing possible exceptions that might be thrown in some System.IO.File methods.

Fixes #2525

@dnfclas
Copy link

dnfclas commented May 30, 2019

CLA assistant check
All CLA requirements met.

@rpetrusha rpetrusha added the ✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository label May 31, 2019
@rpetrusha rpetrusha added this to the May 2019 milestone May 31, 2019
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kaloyankrastev, for contributing to the dotnet/dotnet-api-docs repo and adding the missing exception information. I've suggested a slight change to one of the exception conditions.

If you're planning to open a PR to address a problem you've noticed in the documentation, the extra step of creating an issue before hand is not necessary; you can just submit the PR.

Again, thanks for your contribution. We appreciate it.

Co-Authored-By: Ron Petrusha <[email protected]>
@kaloyankrastev
Copy link
Contributor Author

Hi @rpetrusha,
thanks for having time looking at my pull request. Your suggestion makes perfect sense and I directly committed it, but there is back end engine exception in one of the build tasks. I can not find a proper way to retry the checks. Should I make a a commit with a dummy change in order to trigger the checks?

Again, thanks for taking my suggestions into account!

@MSDN-WhiteKnight
Copy link
Contributor

Try closing/reopening pull request, it should trigger build.

@rpetrusha
Copy link

Thanks for making the additional change, @kaloyankrastev. Your closing and reopening your PR did trigger a new build, which looks good. I'll approve and merge now. The changes should be live on docs.microsoft.com in the next day or two.

@rpetrusha rpetrusha merged commit 2e9b792 into dotnet:master May 31, 2019
@kaloyankrastev kaloyankrastev deleted the patch-1 branch May 31, 2019 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing possible exceptions in System.IO.File documentation
4 participants