Skip to content

Emphasized that String.Copy is obsolete #2546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2019
Merged

Emphasized that String.Copy is obsolete #2546

merged 1 commit into from
Jun 6, 2019

Conversation

rpetrusha
Copy link

@rpetrusha rpetrusha commented Jun 4, 2019 •
edited
Loading

Emphasized that String.Copy is obsolete

Internal review URL

Fixes #2382

//cc @GrabYourPitchforks

@rpetrusha rpetrusha added the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Jun 4, 2019
@rpetrusha rpetrusha added this to the June 2019 milestone Jun 4, 2019
@rpetrusha rpetrusha self-assigned this Jun 4, 2019
This was referenced Jun 4, 2019
Merged
Merged
@BillWagner
Copy link
Member

BillWagner commented Jun 5, 2019 •
edited
Loading

As I read the alternatives to String.Copy, I found myself wondering why Span<char> wasn't mentioned. Would that be an alternative to unsafe code? I think we should recommend using it, or say why we don't in these scenarios.

Update: Well, I read this PR and dotnet/samples#949 in the wrong order. Ignore the above comment.

Beyond that question, this LGTM.

cc @GrabYourPitchforks

BillWagner
BillWagner approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @rpetrusha

You can :shipit: when ready.

@rpetrusha
Copy link
Author

Closing and reopening to begin new build.

@rpetrusha rpetrusha closed this Jun 5, 2019
@rpetrusha rpetrusha reopened this Jun 5, 2019
@rpetrusha rpetrusha merged commit 6ff029f into dotnet:master Jun 6, 2019
@rpetrusha rpetrusha deleted the string-copy branch June 10, 2019 15:21
@mairaw mairaw removed the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees

@rpetrusha rpetrusha

Labels
None yet
Projects
None yet
Milestone
June 2019
Development

Successfully merging this pull request may close these issues.

Need to doc that String.Copy is obsolete as of .NET Core 3
3 participants
@rpetrusha @BillWagner @mairaw