Skip to content

markdig fixes - Part 2 #2552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 6, 2019
Merged

markdig fixes - Part 2 #2552

merged 4 commits into from
Jun 6, 2019

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Jun 5, 2019

No description provided.

@mairaw mairaw added the migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN label Jun 5, 2019
@mairaw mairaw added this to the June 2019 milestone Jun 5, 2019
@mairaw mairaw requested a review from karelz as a code owner June 5, 2019 19:49
@mairaw mairaw self-assigned this Jun 5, 2019
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @mairaw. I've left once comment largely for myself, since the formatting of the ArgumentOutOfRangeException topic is a complete disaster, and I'll fix it after you merge. This is ready to merge.

-

You've attempted to extract a substring that is outside the range of the current string.
- You've attempted to extract a substring that is outside the range of the current string.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting (levels of indentation) in this topic is a complete disaster. I had started to make a list of items that you might easily fix if you wanted, but it's too extensive. I'll open an issue to fix it, and once this is merged, I'll address this issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good @rpetrusha. I've removed one file from this set of changes that needs to be merged after we switch the engine to markdig, otherwise, it breaks what we have right now.

@mairaw mairaw merged commit e88a58b into dotnet:master Jun 6, 2019
@mairaw mairaw deleted the markdig2 branch June 6, 2019 21:28
@rpetrusha rpetrusha mentioned this pull request Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants