Skip to content

markdig fixes - Part 3 #2554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 7, 2019
Merged

markdig fixes - Part 3 #2554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
27b755e
markdig fixes
mairaw Jun 5, 2019
12948c3
add missing langid
mairaw Jun 6, 2019
679616b
Apply suggestions from peer review
mairaw Jun 6, 2019
3f10325
feedback
mairaw Jun 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 1 addition & 26 deletions xml/Microsoft.VisualBasic/FileSystem.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3638,32 +3638,7 @@
<Docs>
<param name="PathName">Required. A string expression that specifies a file, directory, or folder name. <paramref name="PathName" /> can include the directory or folder, and the drive.</param>
<summary>Returns a <see langword="FileAttribute" /> value that represents the attributes of a file, directory, or folder. The <see langword="My" /> feature gives you better productivity and performance in file I/O operations than <see langword="FileAttribute" />. For more information, see <see cref="T:Microsoft.VisualBasic.FileIO.FileSystem" />.</summary>
<returns>The value returned by <see langword="GetAttr" /> is the sum of the following enumeration values:

<list type="table"><item><term> Value

</term><description> Constant

</description><description> Description

</description></item><item><term><see langword="Normal" /></term><description><see langword="vbNormal" /></description><description> Normal.

</description></item><item><term><see langword="ReadOnly" /></term><description><see langword="vbReadOnly" /></description><description> Read-only.

</description></item><item><term><see langword="Hidden" /></term><description><see langword="vbHidden" /></description><description> Hidden.

</description></item><item><term><see langword="System" /></term><description><see langword="vbSystem" /></description><description> System file.

</description></item><item><term><see langword="Directory" /></term><description><see langword="vbDirectory" /></description><description> Directory or folder.

</description></item><item><term><see langword="Archive" /></term><description><see langword="vbArchive" /></description><description> File has changed since last backup.

</description></item><item><term><see langword="Alias" /></term><description><see langword="vbAlias" /></description><description> File has a different name.

</description></item></list><block subset="none" type="note"><para>
These enumerations are specified by the Visual Basic language. The names can be used anywhere in your code in place of the actual values.

</para></block></returns>
<returns>A bitwise combination of the enumeration values.</returns>
<remarks>
<format type="text/markdown"><![CDATA[

Expand Down
18 changes: 9 additions & 9 deletions xml/System.Threading.Tasks/TaskFactory`1.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@
<Docs>
<param name="tasks">The array of tasks from which to continue.</param>
<param name="continuationFunction">The function delegate to execute asynchronously when all tasks in the <paramref name="tasks" /> array have completed.</param>
<param name="continuationOptions">One of the enumeration values that controls the behavior of the created continuation task. The NotOn* or OnlyOn* values are not valid.</param>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The strings NotOn* or OnlyOn* and NotOn* and OnlyOn* are found in a number of other overloads with a TaskContinuationOptions parameter. Do you want to change those as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean in other types @rpetrusha?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. At least I thought that there were additional occurrences in this type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just fixed those.

<param name="continuationOptions">One of the enumeration values that controls the behavior of the created continuation task. The <see langword="NotOn*" /> and <see langword="OnlyOn*" /> values are not valid.</param>
<summary>Creates a continuation task that will be started upon the completion of a set of provided Tasks.</summary>
<returns>The new continuation task.</returns>
<remarks>
Expand Down Expand Up @@ -661,7 +661,7 @@
<param name="tasks">The array of tasks from which to continue.</param>
<param name="continuationFunction">The function delegate to execute asynchronously when all tasks in the <paramref name="tasks" /> array have completed.</param>
<param name="cancellationToken">The cancellation token that will be assigned to the new continuation task.</param>
<param name="continuationOptions">One of the enumeration values that controls the behavior of the created continuation task. The NotOn* or OnlyOn* values are not valid.</param>
<param name="continuationOptions">One of the enumeration values that controls the behavior of the created continuation task. The <see langword="NotOn*" /> and <see langword="OnlyOn*" /> values are not valid.</param>
<param name="scheduler">The scheduler that is used to schedule the created continuation task.</param>
<summary>Creates a continuation task that will be started upon the completion of a set of provided Tasks.</summary>
<returns>The new continuation task.</returns>
Expand Down Expand Up @@ -871,7 +871,7 @@
<typeparam name="TAntecedentResult">The type of the result of the antecedent <paramref name="tasks" />.</typeparam>
<param name="tasks">The array of tasks from which to continue.</param>
<param name="continuationFunction">The function delegate to execute asynchronously when all tasks in the <paramref name="tasks" /> array have completed.</param>
<param name="continuationOptions">One of the enumeration values that controls the behavior of the created continuation task. The NotOn* or OnlyOn* values are not valid.</param>
<param name="continuationOptions">One of the enumeration values that controls the behavior of the created continuation task. The <see langword="NotOn*" /> and <see langword="OnlyOn*" /> values are not valid.</param>
<summary>Creates a continuation task that will be started upon the completion of a set of provided tasks.</summary>
<returns>The new continuation task.</returns>
<remarks>
Expand Down Expand Up @@ -940,7 +940,7 @@
<param name="tasks">The array of tasks from which to continue.</param>
<param name="continuationFunction">The function delegate to execute asynchronously when all tasks in the <paramref name="tasks" /> array have completed.</param>
<param name="cancellationToken">The cancellation token that will be assigned to the new continuation task.</param>
<param name="continuationOptions">One of the enumeration values that controls the behavior of the created continuation task. The NotOn* or OnlyOn* values are not valid.</param>
<param name="continuationOptions">One of the enumeration values that controls the behavior of the created continuation task. The <see langword="NotOn*" /> and <see langword="OnlyOn*" /> values are not valid.</param>
<param name="scheduler">The scheduler that is used to schedule the created continuation task.</param>
<summary>Creates a continuation task that will be started upon the completion of a set of provided tasks.</summary>
<returns>The new continuation task.</returns>
Expand Down Expand Up @@ -1154,7 +1154,7 @@
<Docs>
<param name="tasks">The array of tasks from which to continue when one task completes.</param>
<param name="continuationFunction">The function delegate to execute asynchronously when one task in the <paramref name="tasks" /> array completes.</param>
<param name="continuationOptions">One of the enumeration values that controls the behavior of the created continuation task. The <see langword="NotOn*" /> or <see langword="OnlyOn*" /> values are not valid.</param>
<param name="continuationOptions">One of the enumeration values that controls the behavior of the created continuation task. The <see langword="NotOn*" /> and <see langword="OnlyOn*" /> values are not valid.</param>
<summary>Creates a continuation task that will be started upon the completion of any task in the provided set.</summary>
<returns>The new continuation task.</returns>
<remarks>
Expand Down Expand Up @@ -1223,7 +1223,7 @@
<param name="tasks">The array of tasks from which to continue when one task completes.</param>
<param name="continuationFunction">The function delegate to execute asynchronously when one task in the <paramref name="tasks" /> array completes.</param>
<param name="cancellationToken">The cancellation token that will be assigned to the new continuation task.</param>
<param name="continuationOptions">One of the enumeration values that controls the behavior of the created continuation task. The <see langword="NotOn*" /> or <see langword="OnlyOn*" /> values are not valid.</param>
<param name="continuationOptions">One of the enumeration values that controls the behavior of the created continuation task. The <see langword="NotOn*" /> and <see langword="OnlyOn*" /> values are not valid.</param>
<param name="scheduler">The task scheduler that is used to schedule the created continuation task.</param>
<summary>Creates a continuation task that will be started upon the completion of any task in the provided set.</summary>
<returns>The new continuation task.</returns>
Expand Down Expand Up @@ -1445,7 +1445,7 @@
<typeparam name="TAntecedentResult">The type of the result of the antecedent <paramref name="tasks" />.</typeparam>
<param name="tasks">The array of tasks from which to continue when one task completes.</param>
<param name="continuationFunction">The function delegate to execute asynchronously when one task in the <paramref name="tasks" /> array completes.</param>
<param name="continuationOptions">One of the enumeration values that controls the behavior of the created continuation task. The <see langword="NotOn*" /> or <see langword="OnlyOn*" /> values are not valid.</param>
<param name="continuationOptions">One of the enumeration values that controls the behavior of the created continuation task. The <see langword="NotOn*" /> and <see langword="OnlyOn*" /> values are not valid.</param>
<summary>Creates a continuation task that will be started upon the completion of any task in the provided set.</summary>
<returns>The new continuation <see cref="T:System.Threading.Tasks.Task`1" />.</returns>
<remarks>
Expand Down Expand Up @@ -1518,7 +1518,7 @@
<param name="tasks">The array of tasks from which to continue when one task completes.</param>
<param name="continuationFunction">The function delegate to execute asynchronously when one task in the <paramref name="tasks" /> array completes.</param>
<param name="cancellationToken">The cancellation token that will be assigned to the new continuation task.</param>
<param name="continuationOptions">One of the enumeration values that controls the behavior of the created continuation task. The <see langword="NotOn*" /> or <see langword="OnlyOn*" /> values are not valid.</param>
<param name="continuationOptions">One of the enumeration values that controls the behavior of the created continuation task. The <see langword="NotOn*" /> and <see langword="OnlyOn*" /> values are not valid.</param>
<param name="scheduler">The <see cref="T:System.Threading.Tasks.TaskScheduler" /> that is used to schedule the created continuation <see cref="T:System.Threading.Tasks.Task`1" />.</param>
<summary>Creates a continuation task that will be started upon the completion of any task in the provided set.</summary>
<returns>The new continuation <see cref="T:System.Threading.Tasks.Task`1" />.</returns>
Expand Down Expand Up @@ -2844,4 +2844,4 @@
</Docs>
</Member>
</Members>
</Type>
</Type>
2 changes: 1 addition & 1 deletion xml/System.Web.UI.DataVisualization.Charting/BorderSkinStyle.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
The <xref:System.Web.UI.DataVisualization.Charting.BorderSkin> class represents the style of the border skin used for a chart image. If you set the <xref:System.Web.UI.DataVisualization.Charting.BorderSkin.SkinStyle> property to None, no skin will be used. This is the default value for the <xref:System.Web.UI.DataVisualization.Charting.BorderSkin.SkinStyle> property.

> [!NOTE]
> The difference between the sets of border skin styles that use frames and follow either the naming convention "FrameThin*" or "FrameTitle*" (for example, System.Web.UI.DataVisualization.Charting.BorderSkinStyle.FrameThin1 or System.Web.UI.DataVisualization.Charting.BorderSkinStyle.FrameTitle1) is the shape and thickness of their frames.
> The difference between the sets of border skin styles that use frames and follow either the naming convention "FrameThin\*" or "FrameTitle\*" (for example, System.Web.UI.DataVisualization.Charting.BorderSkinStyle.FrameThin1 or System.Web.UI.DataVisualization.Charting.BorderSkinStyle.FrameTitle1) is the shape and thickness of their frames.

In addition, if you use one of the "FrameThin" style border skins, the title of the chart will not be displayed. However, if you use one of the "FrameTitle" style border skins, the title of the chart will appear in the top-horizontal part of the frame.

Expand Down
24 changes: 12 additions & 12 deletions xml/System.Web.UI.WebControls/AdRotator.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,11 @@
|`Width`|The width of the image, in pixels (optional).|
|`AlternateText`|The text display in place of the image when the image specified by the <xref:System.Web.UI.WebControls.AdCreatedEventArgs.ImageUrl%2A> property is not available (optional).<br /><br /> In some browsers, this text also appears as a `ToolTip` for the advertisement.|
|`Keyword`|A category for the advertisement (for example, "computers") that you can filter by (optional).|
|`Impressions`|A number that indicates the importance of the ad in the schedule of rotation relative to the other ads in the file (optional).<br /><br /> The larger the number, the more often the ad is displayed. The total of all `<Impressions>` values in the XML file cannot exceed 2,047,999,999*.* If it does, the <xref:System.Web.UI.WebControls.AdRotator> control throws a run-time exception.|
|`Impressions`|A number that indicates the importance of the ad in the schedule of rotation relative to the other ads in the file (optional).<br /><br /> The larger the number, the more often the ad is displayed. The total of all `<Impressions>` values in the XML file cannot exceed 2,047,999,999. If it does, the <xref:System.Web.UI.WebControls.AdRotator> control throws a run-time exception.|

The following example shows the format for the XML advertisement file.

```
```xml
<Advertisements>
<Ad>
<ImageUrl>
Expand Down Expand Up @@ -172,7 +172,7 @@

The following code example demonstrates the file format for an XML file that contains advertisement information for the previous example. For more information on the file format, see the <xref:System.Web.UI.WebControls.AdRotator.AdvertisementFile%2A> member.

```
```xml
<Advertisements>
<Ad>
<ImageUrl>~/Images/image1.jpg</ImageUrl>
Expand Down Expand Up @@ -292,7 +292,7 @@

The following code example demonstrates how to format the XML file that contains the advertisement information. For more information on the XML file, see the <xref:System.Web.UI.WebControls.AdRotator.AdvertisementFile%2A> property.

```
```xml
<Advertisements>
<Ad>
<ImageUrl>~/Images/image1.jpg</ImageUrl>
Expand Down Expand Up @@ -418,7 +418,7 @@

The following code example shows the file format of the XML advertisement file.

```
```xml
<Advertisements>
<Ad>
<ImageUrl>~/Images/image1.jpg</ImageUrl>
Expand Down Expand Up @@ -489,7 +489,7 @@

The following is the sample XML data for the previous example.

```
```xml
<Advertisements>
<Ad>
<ImageUrl>~/Images/ad1.gif</ImageUrl>
Expand Down Expand Up @@ -620,7 +620,7 @@

The following is the sample XML data for the previous example.

```
```xml
<Advertisements>
<Ad>
<ImageUrl>~/Images/ad1.gif</ImageUrl>
Expand Down Expand Up @@ -708,7 +708,7 @@

The following code example demonstrates how to specify a keyword for each advertisement in the XML advertisement file. For more information on the file format, see the <xref:System.Web.UI.WebControls.AdRotator.AdvertisementFile%2A> member.

```
```xml
<Advertisements>
<Ad>
<ImageUrl>~/Images/image1.jpg</ImageUrl>
Expand Down Expand Up @@ -778,7 +778,7 @@

The following is the sample XML data for the previous example.

```
```xml
<Advertisements>
<Ad>
<ImageUrl>~/Images/ad1.gif</ImageUrl>
Expand Down Expand Up @@ -854,7 +854,7 @@

The following code example demonstrates how to format the XML file that contains the advertisement information. For more information on the XML file, see the <xref:System.Web.UI.WebControls.AdRotator.AdvertisementFile%2A> property.

```
```xml
<Advertisements>
<Ad>
<ImageUrl>~/Images/image1.jpg</ImageUrl>
Expand Down Expand Up @@ -1164,7 +1164,7 @@

The following code example demonstrates the file format for an XML file that contains advertisement information. For more information on the file format, see the <xref:System.Web.UI.WebControls.AdRotator.AdvertisementFile%2A> member.

```
```xml
<Advertisements>
<Ad>
<ImageUrl>~/Images/image1.jpg</ImageUrl>
Expand Down Expand Up @@ -1226,4 +1226,4 @@
</Docs>
</Member>
</Members>
</Type>
</Type>
4 changes: 0 additions & 4 deletions xml/System.Windows.Forms/KeyPressEventArgs.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,10 +222,6 @@
> [!NOTE]
> For information about how to detect any of the non-character keys mentioned above, see the <xref:System.Windows.Forms.KeyEventArgs> class.

-



## Examples
The following example creates a <xref:System.Windows.Forms.TextBox> control. The `keypressed` method uses the <xref:System.Windows.Forms.KeyPressEventArgs.KeyChar%2A> property to check whether the ENTER key pressed. If the ENTER key is pressed, the <xref:System.Windows.Forms.KeyPressEventArgs.Handled%2A> property is set to `true`, which indicates the event is handled.

Expand Down
2 changes: 1 addition & 1 deletion xml/System.Windows.Media.Media3D/Point3DCollection.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
*oneOrMorePoint3Ds*
One or more <xref:System.Windows.Media.Media3D.Point3D> structures, with each set of values delimited by commas and/or one or more spaces.

<xref:System.Windows.Media.Media3D.Point3D> *[delimiter* <xref:System.Windows.Media.Media3D.Point3D> *]\**
<xref:System.Windows.Media.Media3D.Point3D>_[delimiter_<xref:System.Windows.Media.Media3D.Point3D>_]\*_

For example, `"0,0,5 100,100,125 200,100,30"` and `"0,0,5,100,100,125,200,100,30"` are both valid.

Expand Down
2 changes: 1 addition & 1 deletion xml/System.Windows.Media/Int32Collection.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
*oneOrMoreKInt32Values*
One or more <xref:System.Int32> values, with each pair delimited by a single comma and/or one or more spaces:

<xref:System.Int32> *[delimiter* <xref:System.Int32> *]\**
<xref:System.Int32>_[delimiter_<xref:System.Int32>_]\*_

For example, `"5 10 43"` and `"5,10,43"` are both valid.

Expand Down
2 changes: 1 addition & 1 deletion xml/System.Windows.Media/VectorCollection.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
*oneOrMoreVectors*
One or more vector values, with each pair delimited by a single comma and/or one or more spaces:

<xref:System.Windows.Vector> *[delimiter* <xref:System.Windows.Vector> *]\**
<xref:System.Windows.Vector>_[delimiter_<xref:System.Windows.Vector>_]\*_

For example, `"0,0 100,100 200,100"` and `"0,0,100,100,200,100"` are both valid.

Expand Down
Loading