Skip to content

markdig fixes - Part 4 #2555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2019
Merged

markdig fixes - Part 4 #2555

merged 2 commits into from
Jun 6, 2019

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Jun 5, 2019

No description provided.

@mairaw mairaw added the migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN label Jun 5, 2019
@mairaw mairaw added this to the June 2019 milestone Jun 5, 2019
@mairaw mairaw requested review from karelz and scottaddie as code owners June 5, 2019 21:53
@mairaw mairaw self-assigned this Jun 5, 2019
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, @mairaw, except for one unexpected rendering. You can merge when you're ready.

|\?|Question mark|
|\@|Commercial at-sign|
|\[ \]|Square brackets|
|\\|Backslash|

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has rendered incorrectly:
image
I'm not sure why. Possibly add a space after the escaped backslash?

@mairaw mairaw merged commit f89edb5 into dotnet:master Jun 6, 2019
@mairaw mairaw deleted the markdig4 branch June 6, 2019 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants