-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Restored more enumeration member remarks #2572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left some comments for you to consider @rpetrusha.
|
||
The following table shows how the value of the `collectionKey` and `value` parameter of the <xref:System.Web.Util.RequestValidator.IsValidRequestString%2A?displayProperty=nameWithType> method are interpreted for each member of the `RequestValidationSource` enumeration. | ||
|
||
|Enumeration member|`collectionKey` parameter|`value` parameter| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great way to consolidate those remarks!
<format type="text/markdown"><![CDATA[ | ||
|
||
## Remarks | ||
<xref:System.Workflow.ComponentModel.TerminateActivity> activity, by a call to <xref:System.Workflow.Runtime.WorkflowInstance.Terminate%2A?displayProperty=nameWithType>, or by the workflow runtime engine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be moved to the summary, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it should. I'd clearly started to move it but somehow left most of the text.
Thanks for the careful review, @mairaw! Co-Authored-By: Maira Wenzel <[email protected]>
Restored more enumeration member remarks
Contributes to #1306