Skip to content

Restored more enumeration member remarks #2572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 13, 2019

Conversation

rpetrusha
Copy link

Restored more enumeration member remarks

Contributes to #1306

@rpetrusha rpetrusha added this to the June 2019 milestone Jun 7, 2019
@rpetrusha rpetrusha requested a review from scottaddie as a code owner June 7, 2019 22:34
@rpetrusha rpetrusha self-assigned this Jun 7, 2019
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some comments for you to consider @rpetrusha.


The following table shows how the value of the `collectionKey` and `value` parameter of the <xref:System.Web.Util.RequestValidator.IsValidRequestString%2A?displayProperty=nameWithType> method are interpreted for each member of the `RequestValidationSource` enumeration.

|Enumeration member|`collectionKey` parameter|`value` parameter|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great way to consolidate those remarks!

<format type="text/markdown"><![CDATA[

## Remarks
<xref:System.Workflow.ComponentModel.TerminateActivity> activity, by a call to <xref:System.Workflow.Runtime.WorkflowInstance.Terminate%2A?displayProperty=nameWithType>, or by the workflow runtime engine.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be moved to the summary, no?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should. I'd clearly started to move it but somehow left most of the text.

Thanks for the careful review, @mairaw!

Co-Authored-By: Maira Wenzel <[email protected]>
@rpetrusha rpetrusha added the migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN label Jun 11, 2019
@rpetrusha rpetrusha merged commit 752ea35 into dotnet:master Jun 13, 2019
@rpetrusha rpetrusha deleted the enum-remarks5 branch June 13, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants