Add documentation for IAsyncDisposable #2575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on source code comments (https://github.com/dotnet/corefx/blob/master/src/Common/src/CoreLib/System/IAsyncDisposable.cs) and Async Streams proposal description (https://github.com/dotnet/csharplang/blob/master/proposals/csharp-8.0/async-streams.md).
rpetrusha
approved these changes
Jun 10, 2019
There was a problem hiding this comment.
Thank you for documenting IAsyncDisposable, @MSDN-WhiteKnight. I've left a number of suggestions.
rpetrusha
suggested changes
Jun 10, 2019
There was a problem hiding this comment.
Sorry, @MSDN-WhiteKnight. I'd intended to request changes rather than approve.
Co-Authored-By: Ron Petrusha <[email protected]>
rpetrusha
approved these changes
Jun 13, 2019
|
Thank you for making the additional changes, @MSDN-WhiteKnight. I'll merge your PR now. The documentation should be live on docs.microsoft.com in the next day or two. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Based on source code comments and Async Streams proposal description.