Skip to content

Removed ambiguity in matched pattern. #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2019
Merged

Conversation

AbhiAbzs
Copy link
Contributor

Summary

The pattern for Sales*200?.xls filter string wasn't correct.

The pattern for Sales*200?.xls filter string wasn't correct.
@BillWagner BillWagner requested a review from rpetrusha June 12, 2019 15:08
@rpetrusha rpetrusha added this to the June 2019 milestone Jun 12, 2019
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @AbhiAbzs, for contributing to the dotnet/dotnet-api-docs repo and adding clarity to the matched filenames. I thought that the formatting could be improved to make the text clearer still, so I've suggested some changes.

Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My original suggested change appears to have been lost.

Additional changes were made for better readability.

Co-Authored-By: Ron Petrusha <[email protected]>
@mairaw mairaw added the changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review label Jun 14, 2019
@rpetrusha
Copy link

Thank you for making the additional changes, @AbhiAbzs. We'll merge your PR now. Your changes should be live on docs.microsoft.com in the next day or two.

@rpetrusha rpetrusha merged commit 6bdf823 into dotnet:master Jun 17, 2019
@mairaw mairaw removed the changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review label Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants