Skip to content

Minor Fix #2590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2019
Merged

Minor Fix #2590

merged 2 commits into from
Jun 24, 2019

Conversation

geekycrooner
Copy link
Contributor

Summary

Changed "following" to "previous".

@geekycrooner geekycrooner requested a review from scottaddie as a code owner June 12, 2019 15:19
@rpetrusha rpetrusha added this to the June 2019 milestone Jun 12, 2019
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @geekycrooner, for contributing to the dotnet/dotnet-api-docs repo and removing the incorrect mention of an example that follows the remarks. A better option, though, is to not mention the position of the example relative to the remarks. I've suggested a link to the examples section instead.

@mairaw mairaw added the ✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository label Jun 19, 2019
@mairaw
Copy link
Contributor

mairaw commented Jun 19, 2019

@geekycrooner can you please click on the button to accept @rpetrusha's suggestion?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants