-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Added link in AesManaged to article warning of timing vulnerabilities… #2609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… with CBC-mode symmetric decryption using padding.
Seems fine to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @samrueby. Just have a small edit request before merging this.
It would probably be good to add this info to the Mode property remarks as well. |
Co-Authored-By: Maira Wenzel <[email protected]>
Possibly- but according to the article a lot of other types are apparently affected too: Aes Should all of them be updated? |
@bartonjs can you comment on that? |
Yes, all of those named types are similarly affected (by having CBC+PKCS7 be the default and CBC with any removable padding being what has the vulnerabilty). |
@samrueby Do you want to update all of the other types you listed, or should we merge this PR and create an issue to track the work of updating the others? |
At this point, I think we should merge this, and create a new issue for the remaining changes. Do you agree? |
… with CBC-mode symmetric decryption using padding.
Summary
Added a link to an important article from Microsoft about the latest recommendations for securely handling encrypted data while using CBC mode, which is the default for this class.