-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Document System.Runtime.AmbiguousImplementationException #2796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document System.Runtime.AmbiguousImplementationException #2796
Conversation
Do we want to add a remarks section? Something along the lines of:
(Took the inspiration from MissingMethodException.) |
Co-Authored-By: Jeremy Barton <[email protected]>
@MichalStrehovsky I'd be glad to add your remark message. Do you want me to add it to the general |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for documenting this exception type, @carlossanlop. I've left a comment and a couple of suggestions.
Co-Authored-By: Ron Petrusha <[email protected]>
@rpetrusha comments addressed, build passed. Is it good to merge? |
Yes, it's good to merge, @carlossanlop. I'll do that now. |
Here's the original proposal for the exception: https://github.com/dotnet/corefx/issues/34124
Here's the PR that introduced it: dotnet/coreclr#22280
Adding @MichalStrehovsky who proposed the API and @jkotas who approved it.