Skip to content

Docs for VersionConverter #2801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 23, 2019
Merged

Docs for VersionConverter #2801

merged 4 commits into from
Jul 23, 2019

Conversation

maryamariyan
Copy link
Contributor

cc: @carlossanlop

added docs for undocumented API.

@carlossanlop carlossanlop added 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Jul 23, 2019
@maryamariyan maryamariyan changed the title Docs for VersionConverter.IsValid Docs for VersionConverter Jul 23, 2019
carlossanlop
carlossanlop reviewed Jul 23, 2019
View reviewed changes
carlossanlop
carlossanlop reviewed Jul 23, 2019
View reviewed changes
carlossanlop
carlossanlop reviewed Jul 23, 2019
View reviewed changes
carlossanlop
carlossanlop reviewed Jul 23, 2019
View reviewed changes
carlossanlop
carlossanlop reviewed Jul 23, 2019
View reviewed changes
mairaw
mairaw reviewed Jul 23, 2019
View reviewed changes
mairaw
mairaw requested changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good overall. Just needs some suggestions addressed.

@mairaw mairaw removed the request for review from rpetrusha July 23, 2019 17:57
@mairaw mairaw added this to the July 2019 milestone Jul 23, 2019
@mairaw mairaw added verify-build-before-merge and removed waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Jul 23, 2019
@maryamariyan
Copy link
Contributor Author

@mairaw @carlossanlop thanks for your review. the PR is ready again for your review.

carlossanlop
carlossanlop approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mairaw mairaw merged commit 1a08bff into dotnet:master Jul 23, 2019
@maryamariyan maryamariyan deleted the version-converter-apis branch July 23, 2019 20:31
safern
safern reviewed Jul 23, 2019
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@safern safern safern left review comments

@mairaw mairaw mairaw approved these changes

+1 more reviewer

@carlossanlop carlossanlop carlossanlop approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@maryamariyan maryamariyan

Labels
🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles
Projects
None yet
Milestone
July 2019
Development

Successfully merging this pull request may close these issues.
4 participants
@maryamariyan @carlossanlop @mairaw @safern