-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Document System.Text.RegularExpressions.GroupCollection #2803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document System.Text.RegularExpressions.GroupCollection #2803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a number of comments and suggestions, @carlossanlop. Most importantly, the members that you removed should be restored, since they evidently were supported in .NET Core 1.0 and 1.1.
4bb2089
to
fa094d6
Compare
I addressed your comments, @rpetrusha. I had to to a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, @carlossanlop. I thought that there were a few more places where we should add "This is an explicit interface implementation..."
Co-Authored-By: Ron Petrusha <[email protected]>
@mairaw @rpetrusha I applied your suggestions Ron, thanks for finding the additional remarks. I modified them a bit to include CDATA, otherwise the xrefs would give us trouble. Let me know if they look good while we wait for the build to finish. |
This looks good, @carlossanlop. I just noticed that there's one more EII (ICollection.CopyTo) that could have the "This member is an EII..." text, but I'll open a PR to add it separately, and I'll merge your PR now. |
This one was interesting because the class implements IList and ICollection, which have shared method names.
Strangely, there were a couple of members that were duplicate, so I removed them. Please let me know if it was wrong to do so.
Here is the code: GroupCollection.cs
I based the documentation on the interface comments:
Area owners: @ViktorHofer, @maryamariyan
Language review: @rpetrusha, @Jemash