Skip to content

Add missing Zip API docs #2816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2019
Merged

Add missing Zip API docs #2816

merged 2 commits into from
Jul 26, 2019

Conversation

maryamariyan
Copy link
Contributor

@maryamariyan maryamariyan commented Jul 24, 2019

cc: @stephentoub @carlossanlop

Here are the two APIs with missing docs:

namespace System.Linq
{
    public static class Enumerable
    {
        public static IEnumerable<ValueTuple<TFirst, TSecond>> Zip<TFirst, TSecond>(this IEnumerable<TFirst> first, IEnumerable<TSecond> second);
    } 

    public static class Queryable
    {
        public static IQueryable<ValueTuple<TFirst, TSecond>> Zip<TFirst, TSecond>(this IQueryable<TFirst> source1, IEnumerable<TSecond> source2);
    }
}

And sample tests in corefx showing their usages:
https://github.com/dotnet/corefx/blob/master/src/System.Linq/tests/ZipTests.netcoreapp.cs
https://github.com/dotnet/corefx/blob/master/src/System.Linq.Queryable/tests/ZipTests.netcoreapp.cs

@carlossanlop carlossanlop added 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Jul 24, 2019
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall @maryamariyan. Left some comments/questions in addition to @stephentoub's comments.

@mairaw mairaw added this to the July 2019 milestone Jul 24, 2019
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Language-wise LGTM. @stephentoub good to merge?

@mairaw mairaw merged commit ead68ff into dotnet:master Jul 26, 2019
@mairaw mairaw removed the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants