Skip to content

style guide + missing sections #2827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2019
Merged

style guide + missing sections #2827

merged 2 commits into from
Jul 26, 2019

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Jul 25, 2019

No description provided.

@mairaw mairaw added this to the July 2019 milestone Jul 25, 2019
@mairaw mairaw requested a review from carlossanlop July 25, 2019 18:56
@mairaw mairaw self-assigned this Jul 25, 2019
carlossanlop
carlossanlop approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @mairaw. Thanks for adding the missing info.
CC @layomia , who owns System.Buffers. You can skip the <returns> values Maira documented in this PR when you document your APIs.

@mairaw
Copy link
Contributor Author

mairaw commented Jul 25, 2019

Do I need to wait for @layomia's review or can this be merged? The changes were pretty straightforward.

@layomia
Copy link
Contributor

layomia commented Jul 25, 2019

LGTM.

@mairaw mairaw merged commit 67552e6 into master Jul 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the mairaw-patch-1 branch July 26, 2019 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@carlossanlop carlossanlop carlossanlop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mairaw mairaw

Labels

None yet

Projects

None yet

Milestone

July 2019

Development

Successfully merging this pull request may close these issues.

3 participants

@mairaw @layomia @carlossanlop